Changeset 42343 for trunk/src/wp-admin/includes/class-automatic-upgrader-skin.php

Timestamp:

11/30/2017 11:09:33 PM (7 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-admin/includes/class-automatic-upgrader-skin.php (modified) (5 diffs)

trunk/src/wp-admin/includes/class-automatic-upgrader-skin.php

@@ -51 +51 @@
 
     /**
-     *
      * @return array
      */
@@ -59 +58 @@
 
     /**
-     *
      * @param string|array|WP_Error $data
      */
@@ -70 +68 @@
             $string = $data;
         }
-        if ( ! empty( $this->upgrader->strings[ $string ] ) )
+        if ( ! empty( $this->upgrader->strings[ $string ] ) ) {
             $string = $this->upgrader->strings[ $string ];
+        }
 
         if ( strpos( $string, '%' ) !== false ) {
             $args = func_get_args();
             $args = array_splice( $args, 1 );
-            if ( ! empty( $args ) )
+            if ( ! empty( $args ) ) {
                 $string = vsprintf( $string, $args );
+            }
         }
 
@@ -83 +83 @@
 
         // Only allow basic HTML in the messages, as it'll be used in emails/logs rather than direct browser output.
-        $string = wp_kses( $string, array(
-            'a' => array(
-                'href' => true
-            ),
-            'br' => true,
-            'em' => true,
-            'strong' => true,
-        ) );
+        $string = wp_kses(
+            $string, array(
+                'a'      => array(
+                    'href' => true,
+                ),
+                'br'     => true,
+                'em'     => true,
+                'strong' => true,
+            )
+        );
 
-        if ( empty( $string ) )
+        if ( empty( $string ) ) {
             return;
+        }
 
         $this->messages[] = $string;
@@ -108 +111 @@
     public function footer() {
         $output = ob_get_clean();
-        if ( ! empty( $output ) )
+        if ( ! empty( $output ) ) {
             $this->feedback( $output );
+        }
     }
 }