Changeset 42343 for trunk/src/wp-admin/includes/class-language-pack-upgrader.php

Timestamp:

11/30/2017 11:09:33 PM (8 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-admin/includes/class-language-pack-upgrader.php (modified) (12 diffs)

trunk/src/wp-admin/includes/class-language-pack-upgrader.php

@@ -95 +95 @@
             $skin = $upgrader->skin;
         } else {
-            $skin = new Language_Pack_Upgrader_Skin( array(
-                'skip_header_footer' => true,
-            ) );
+            $skin = new Language_Pack_Upgrader_Skin(
+                array(
+                    'skip_header_footer' => true,
+                )
+            );
         }
 
@@ -111 +113 @@
     public function upgrade_strings() {
         $this->strings['starting_upgrade'] = __( 'Some of your translations need updating. Sit tight for a few more seconds while we update them as well.' );
-        $this->strings['up_to_date'] = __( 'The translations are up to date.' );
-        $this->strings['no_package'] = __( 'Update package not available.' );
+        $this->strings['up_to_date']       = __( 'The translations are up to date.' );
+        $this->strings['no_package']       = __( 'Update package not available.' );
         /* translators: %s: package URL */
         $this->strings['downloading_package'] = sprintf( __( 'Downloading translation from %s&#8230;' ), '<span class="code">%s</span>' );
-        $this->strings['unpack_package'] = __( 'Unpacking the update&#8230;' );
-        $this->strings['process_failed'] = __( 'Translation update failed.' );
-        $this->strings['process_success'] = __( 'Translation updated successfully.' );
+        $this->strings['unpack_package']      = __( 'Unpacking the update&#8230;' );
+        $this->strings['process_failed']      = __( 'Translation update failed.' );
+        $this->strings['process_success']     = __( 'Translation updated successfully.' );
     }
 
@@ -164 +166 @@
         global $wp_filesystem;
 
-        $defaults = array(
+        $defaults    = array(
             'clear_update_cache' => true,
         );
@@ -172 +174 @@
         $this->upgrade_strings();
 
-        if ( ! $language_updates )
+        if ( ! $language_updates ) {
             $language_updates = wp_get_translation_updates();
+        }
 
         if ( empty( $language_updates ) ) {
@@ -184 +187 @@
         }
 
-        if ( 'upgrader_process_complete' == current_filter() )
+        if ( 'upgrader_process_complete' == current_filter() ) {
             $this->skin->feedback( 'starting_upgrade' );
+        }
 
         // Remove any existing upgrade filters from the plugin/theme upgraders #WP29425 & #WP29230
@@ -206 +210 @@
         $results = array();
 
-        $this->update_count = count( $language_updates );
+        $this->update_count   = count( $language_updates );
         $this->update_current = 0;
 
@@ -214 +218 @@
          */
         $remote_destination = $wp_filesystem->find_folder( WP_LANG_DIR );
-        if ( ! $wp_filesystem->exists( $remote_destination ) )
-            if ( ! $wp_filesystem->mkdir( $remote_destination, FS_CHMOD_DIR ) )
+        if ( ! $wp_filesystem->exists( $remote_destination ) ) {
+            if ( ! $wp_filesystem->mkdir( $remote_destination, FS_CHMOD_DIR ) ) {
                 return new WP_Error( 'mkdir_failed_lang_dir', $this->strings['mkdir_failed'], $remote_destination );
+            }
+        }
 
         $language_updates_results = array();
@@ -225 +231 @@
 
             $destination = WP_LANG_DIR;
-            if ( 'plugin' == $language_update->type )
+            if ( 'plugin' == $language_update->type ) {
                 $destination .= '/plugins';
-            elseif ( 'theme' == $language_update->type )
+            } elseif ( 'theme' == $language_update->type ) {
                 $destination .= '/themes';
+            }
 
             $this->update_current++;
 
             $options = array(
-                'package' => $language_update->package,
-                'destination' => $destination,
-                'clear_destination' => false,
+                'package'                     => $language_update->package,
+                'destination'                 => $destination,
+                'clear_destination'           => false,
                 'abort_if_destination_exists' => false, // We expect the destination to exist.
-                'clear_working' => true,
-                'is_multi' => true,
-                'hook_extra' => array(
+                'clear_working'               => true,
+                'is_multi'                    => true,
+                'hook_extra'                  => array(
                     'language_update_type' => $language_update->type,
-                    'language_update' => $language_update,
-                )
+                    'language_update'      => $language_update,
+                ),
             );
 
@@ -269 +276 @@
 
         /** This action is documented in wp-admin/includes/class-wp-upgrader.php */
-        do_action( 'upgrader_process_complete', $this, array(
-            'action'       => 'update',
-            'type'         => 'translation',
-            'bulk'         => true,
-            'translations' => $language_updates_results
-        ) );
+        do_action(
+            'upgrader_process_complete', $this, array(
+                'action'       => 'update',
+                'type'         => 'translation',
+                'bulk'         => true,
+                'translations' => $language_updates_results,
+            )
+        );
 
         // Re-add upgrade hooks.
@@ -312 +321 @@
         global $wp_filesystem;
 
-        if ( is_wp_error( $source ) )
+        if ( is_wp_error( $source ) ) {
             return $source;
+        }
 
         // Check that the folder contains a valid language.
@@ -321 +331 @@
         $po = $mo = false;
         foreach ( (array) $files as $file => $filedata ) {
-            if ( '.po' == substr( $file, -3 ) )
+            if ( '.po' == substr( $file, -3 ) ) {
                 $po = true;
-            elseif ( '.mo' == substr( $file, -3 ) )
+            } elseif ( '.mo' == substr( $file, -3 ) ) {
                 $mo = true;
+            }
         }
 
         if ( ! $mo || ! $po ) {
-            return new WP_Error( 'incompatible_archive_pomo', $this->strings['incompatible_archive'],
+            return new WP_Error(
+                'incompatible_archive_pomo', $this->strings['incompatible_archive'],
                 /* translators: 1: .po 2: .mo */
-                sprintf( __( 'The language pack is missing either the %1$s or %2$s files.' ),
+                sprintf(
+                    __( 'The language pack is missing either the %1$s or %2$s files.' ),
                     '<code>.po</code>',
                     '<code>.mo</code>'
@@ -355 +368 @@
             case 'theme':
                 $theme = wp_get_theme( $update->slug );
-                if ( $theme->exists() )
+                if ( $theme->exists() ) {
                     return $theme->Get( 'Name' );
+                }
                 break;
             case 'plugin':
                 $plugin_data = get_plugins( '/' . $update->slug );
                 $plugin_data = reset( $plugin_data );
-                if ( $plugin_data )
+                if ( $plugin_data ) {
                     return $plugin_data['Name'];
+                }
                 break;
         }