Changeset 42343 for trunk/src/wp-admin/includes/class-plugin-upgrader-skin.php

Timestamp:

11/30/2017 11:09:33 PM (6 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-admin/includes/class-plugin-upgrader-skin.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-plugin-upgrader-skin.php

@@ -17 +17 @@
  */
 class Plugin_Upgrader_Skin extends WP_Upgrader_Skin {
-    public $plugin = '';
-    public $plugin_active = false;
+    public $plugin                = '';
+    public $plugin_active         = false;
     public $plugin_network_active = false;
 
     /**
-     *
      * @param array $args
      */
     public function __construct( $args = array() ) {
-        $defaults = array( 'url' => '', 'plugin' => '', 'nonce' => '', 'title' => __('Update Plugin') );
-        $args = wp_parse_args($args, $defaults);
+        $defaults = array(
+            'url'    => '',
+            'plugin' => '',
+            'nonce'  => '',
+            'title'  => __( 'Update Plugin' ),
+        );
+        $args     = wp_parse_args( $args, $defaults );
 
         $this->plugin = $args['plugin'];
 
-        $this->plugin_active = is_plugin_active( $this->plugin );
+        $this->plugin_active         = is_plugin_active( $this->plugin );
         $this->plugin_network_active = is_plugin_active_for_network( $this->plugin );
 
-        parent::__construct($args);
+        parent::__construct( $args );
     }
 
@@ -41 +45 @@
     public function after() {
         $this->plugin = $this->upgrader->plugin_info();
-        if ( !empty($this->plugin) && !is_wp_error($this->result) && $this->plugin_active ){
+        if ( ! empty( $this->plugin ) && ! is_wp_error( $this->result ) && $this->plugin_active ) {
             // Currently used only when JS is off for a single plugin update?
             echo '<iframe title="' . esc_attr__( 'Update progress' ) . '" style="border:0;overflow:hidden" width="100%" height="170" src="' . wp_nonce_url( 'update.php?action=activate-plugin&networkwide=' . $this->plugin_network_active . '&plugin=' . urlencode( $this->plugin ), 'activate-plugin_' . $this->plugin ) . '"></iframe>';
@@ -48 +52 @@
         $this->decrement_update_count( 'plugin' );
 
-        $update_actions =  array(
-            'activate_plugin' => '<a href="' . wp_nonce_url( 'plugins.php?action=activate&amp;plugin=' . urlencode( $this->plugin ), 'activate-plugin_' . $this->plugin) . '" target="_parent">' . __( 'Activate Plugin' ) . '</a>',
-            'plugins_page' => '<a href="' . self_admin_url( 'plugins.php' ) . '" target="_parent">' . __( 'Return to Plugins page' ) . '</a>'
+        $update_actions = array(
+            'activate_plugin' => '<a href="' . wp_nonce_url( 'plugins.php?action=activate&amp;plugin=' . urlencode( $this->plugin ), 'activate-plugin_' . $this->plugin ) . '" target="_parent">' . __( 'Activate Plugin' ) . '</a>',
+            'plugins_page'    => '<a href="' . self_admin_url( 'plugins.php' ) . '" target="_parent">' . __( 'Return to Plugins page' ) . '</a>',
         );
-        if ( $this->plugin_active || ! $this->result || is_wp_error( $this->result ) || ! current_user_can( 'activate_plugin', $this->plugin ) )
+        if ( $this->plugin_active || ! $this->result || is_wp_error( $this->result ) || ! current_user_can( 'activate_plugin', $this->plugin ) ) {
             unset( $update_actions['activate_plugin'] );
+        }
 
         /**
@@ -65 +70 @@
         $update_actions = apply_filters( 'update_plugin_complete_actions', $update_actions, $this->plugin );
 
-        if ( ! empty($update_actions) )
-            $this->feedback(implode(' | ', (array)$update_actions));
+        if ( ! empty( $update_actions ) ) {
+            $this->feedback( implode( ' | ', (array) $update_actions ) );
+        }
     }
 }