Changeset 42343 for trunk/src/wp-admin/includes/class-theme-installer-skin.php

Timestamp:

11/30/2017 11:09:33 PM (7 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-admin/includes/class-theme-installer-skin.php (modified) (6 diffs)

trunk/src/wp-admin/includes/class-theme-installer-skin.php

@@ -21 +21 @@
 
     /**
-     *
      * @param array $args
      */
-    public function __construct($args = array()) {
-        $defaults = array( 'type' => 'web', 'url' => '', 'theme' => '', 'nonce' => '', 'title' => '' );
-        $args = wp_parse_args($args, $defaults);
+    public function __construct( $args = array() ) {
+        $defaults = array(
+            'type'  => 'web',
+            'url'   => '',
+            'theme' => '',
+            'nonce' => '',
+            'title' => '',
+        );
+        $args     = wp_parse_args( $args, $defaults );
 
         $this->type = $args['type'];
-        $this->api = isset($args['api']) ? $args['api'] : array();
+        $this->api  = isset( $args['api'] ) ? $args['api'] : array();
 
-        parent::__construct($args);
+        parent::__construct( $args );
     }
 
@@ -37 +42 @@
      */
     public function before() {
-        if ( !empty($this->api) )
-            $this->upgrader->strings['process_success'] = sprintf( $this->upgrader->strings['process_success_specific'], $this->api->name, $this->api->version);
+        if ( ! empty( $this->api ) ) {
+            $this->upgrader->strings['process_success'] = sprintf( $this->upgrader->strings['process_success_specific'], $this->api->name, $this->api->version );
+        }
     }
 
@@ -44 +50 @@
      */
     public function after() {
-        if ( empty($this->upgrader->result['destination_name']) )
+        if ( empty( $this->upgrader->result['destination_name'] ) ) {
             return;
+        }
 
         $theme_info = $this->upgrader->theme_info();
-        if ( empty( $theme_info ) )
+        if ( empty( $theme_info ) ) {
             return;
+        }
 
-        $name       = $theme_info->display('Name');
+        $name       = $theme_info->display( 'Name' );
         $stylesheet = $this->upgrader->result['destination_name'];
         $template   = $theme_info->get_template();
 
-        $activate_link = add_query_arg( array(
-            'action'     => 'activate',
-            'template'   => urlencode( $template ),
-            'stylesheet' => urlencode( $stylesheet ),
-        ), admin_url('themes.php') );
+        $activate_link = add_query_arg(
+            array(
+                'action'     => 'activate',
+                'template'   => urlencode( $template ),
+                'stylesheet' => urlencode( $stylesheet ),
+            ), admin_url( 'themes.php' )
+        );
         $activate_link = wp_nonce_url( $activate_link, 'switch-theme_' . $stylesheet );
 
@@ -65 +75 @@
 
         if ( current_user_can( 'edit_theme_options' ) && current_user_can( 'customize' ) ) {
-            $customize_url = add_query_arg(
+            $customize_url              = add_query_arg(
                 array(
-                    'theme' => urlencode( $stylesheet ),
+                    'theme'  => urlencode( $stylesheet ),
                     'return' => urlencode( admin_url( 'web' === $this->type ? 'theme-install.php' : 'themes.php' ) ),
                 ),
@@ -76 +86 @@
         $install_actions['activate'] = '<a href="' . esc_url( $activate_link ) . '" class="activatelink"><span aria-hidden="true">' . __( 'Activate' ) . '</span><span class="screen-reader-text">' . sprintf( __( 'Activate &#8220;%s&#8221;' ), $name ) . '</span></a>';
 
-        if ( is_network_admin() && current_user_can( 'manage_network_themes' ) )
+        if ( is_network_admin() && current_user_can( 'manage_network_themes' ) ) {
             $install_actions['network_enable'] = '<a href="' . esc_url( wp_nonce_url( 'themes.php?action=enable&amp;theme=' . urlencode( $stylesheet ), 'enable-theme_' . $stylesheet ) ) . '" target="_parent">' . __( 'Network Enable' ) . '</a>';
+        }
 
-        if ( $this->type == 'web' )
+        if ( $this->type == 'web' ) {
             $install_actions['themes_page'] = '<a href="' . self_admin_url( 'theme-install.php' ) . '" target="_parent">' . __( 'Return to Theme Installer' ) . '</a>';
-        elseif ( current_user_can( 'switch_themes' ) || current_user_can( 'edit_theme_options' ) )
+        } elseif ( current_user_can( 'switch_themes' ) || current_user_can( 'edit_theme_options' ) ) {
             $install_actions['themes_page'] = '<a href="' . self_admin_url( 'themes.php' ) . '" target="_parent">' . __( 'Return to Themes page' ) . '</a>';
+        }
 
-        if ( ! $this->result || is_wp_error($this->result) || is_network_admin() || ! current_user_can( 'switch_themes' ) )
+        if ( ! $this->result || is_wp_error( $this->result ) || is_network_admin() || ! current_user_can( 'switch_themes' ) ) {
             unset( $install_actions['activate'], $install_actions['preview'] );
+        }
 
         /**
@@ -98 +111 @@
          */
         $install_actions = apply_filters( 'install_theme_complete_actions', $install_actions, $this->api, $stylesheet, $theme_info );
-        if ( ! empty($install_actions) )
-            $this->feedback(implode(' | ', (array)$install_actions));
+        if ( ! empty( $install_actions ) ) {
+            $this->feedback( implode( ' | ', (array) $install_actions ) );
+        }
     }
 }