Changeset 42343 for trunk/src/wp-admin/link-parse-opml.php

Timestamp:

11/30/2017 11:09:33 PM (8 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-admin/link-parse-opml.php (modified) (6 diffs)

trunk/src/wp-admin/link-parse-opml.php

@@ -7 +7 @@
  */
 
-if ( ! defined('ABSPATH') )
+if ( ! defined( 'ABSPATH' ) ) {
     die();
+}
 
 /**
@@ -31 +32 @@
  * @param array $attrs XML element attributes.
  */
-function startElement($parser, $tagName, $attrs) {
+function startElement( $parser, $tagName, $attrs ) {
     global $names, $urls, $targets, $descriptions, $feeds;
 
@@ -51 +52 @@
 
         // Save the data away.
-        $names[] = $name;
-        $urls[] = $url;
-        $targets[] = isset( $attrs['TARGET'] ) ? $attrs['TARGET'] :  '';
-        $feeds[] = isset( $attrs['XMLURL'] ) ? $attrs['XMLURL'] :  '';
-        $descriptions[] = isset( $attrs['DESCRIPTION'] ) ? $attrs['DESCRIPTION'] :  '';
+        $names[]        = $name;
+        $urls[]         = $url;
+        $targets[]      = isset( $attrs['TARGET'] ) ? $attrs['TARGET'] : '';
+        $feeds[]        = isset( $attrs['XMLURL'] ) ? $attrs['XMLURL'] : '';
+        $descriptions[] = isset( $attrs['DESCRIPTION'] ) ? $attrs['DESCRIPTION'] : '';
     } // End if outline.
 }
@@ -68 +69 @@
  * @param string $tagName XML tag name.
  */
-function endElement($parser, $tagName) {
+function endElement( $parser, $tagName ) {
     // Nothing to do.
 }
@@ -81 +82 @@
 
 // Set the functions to handle opening and closing tags
-xml_set_element_handler($xml_parser, "startElement", "endElement");
+xml_set_element_handler( $xml_parser, 'startElement', 'endElement' );
 
 if ( ! xml_parse( $xml_parser, $opml, true ) ) {
@@ -93 +94 @@
 
 // Free up memory used by the XML parser
-xml_parser_free($xml_parser);
+xml_parser_free( $xml_parser );