Make WordPress Core


Ignore:
Timestamp:
11/30/2017 11:09:33 PM (6 years ago)
Author:
pento
Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/src/wp-admin/link.php

    r38028 r42343  
    1515wp_reset_vars( array( 'action', 'cat_id', 'link_id' ) );
    1616
    17 if ( ! current_user_can('manage_links') )
     17if ( ! current_user_can( 'manage_links' ) ) {
    1818    wp_link_manager_disabled_message();
     19}
    1920
    20 if ( !empty($_POST['deletebookmarks']) )
     21if ( ! empty( $_POST['deletebookmarks'] ) ) {
    2122    $action = 'deletebookmarks';
    22 if ( !empty($_POST['move']) )
     23}
     24if ( ! empty( $_POST['move'] ) ) {
    2325    $action = 'move';
    24 if ( !empty($_POST['linkcheck']) )
     26}
     27if ( ! empty( $_POST['linkcheck'] ) ) {
    2528    $linkcheck = $_POST['linkcheck'];
     29}
    2630
    27 $this_file = admin_url('link-manager.php');
     31$this_file = admin_url( 'link-manager.php' );
    2832
    29 switch ($action) {
    30     case 'deletebookmarks' :
    31         check_admin_referer('bulk-bookmarks');
     33switch ( $action ) {
     34    case 'deletebookmarks':
     35        check_admin_referer( 'bulk-bookmarks' );
    3236
    3337        // For each link id (in $linkcheck[]) change category to selected value.
    34         if (count($linkcheck) == 0) {
    35             wp_redirect($this_file);
     38        if ( count( $linkcheck ) == 0 ) {
     39            wp_redirect( $this_file );
    3640            exit;
    3741        }
    3842
    3943        $deleted = 0;
    40         foreach ($linkcheck as $link_id) {
     44        foreach ( $linkcheck as $link_id ) {
    4145            $link_id = (int) $link_id;
    4246
    43             if ( wp_delete_link($link_id) )
     47            if ( wp_delete_link( $link_id ) ) {
    4448                $deleted++;
     49            }
    4550        }
    4651
    47         wp_redirect("$this_file?deleted=$deleted");
     52        wp_redirect( "$this_file?deleted=$deleted" );
    4853        exit;
    4954
    50     case 'move' :
    51         check_admin_referer('bulk-bookmarks');
     55    case 'move':
     56        check_admin_referer( 'bulk-bookmarks' );
    5257
    5358        // For each link id (in $linkcheck[]) change category to selected value.
    54         if (count($linkcheck) == 0) {
    55             wp_redirect($this_file);
     59        if ( count( $linkcheck ) == 0 ) {
     60            wp_redirect( $this_file );
    5661            exit;
    5762        }
    58         $all_links = join(',', $linkcheck);
     63        $all_links = join( ',', $linkcheck );
    5964        /*
    6065         * Should now have an array of links we can change:
     
    6267         */
    6368
    64         wp_redirect($this_file);
     69        wp_redirect( $this_file );
    6570        exit;
    6671
    67     case 'add' :
    68         check_admin_referer('add-bookmark');
     72    case 'add':
     73        check_admin_referer( 'add-bookmark' );
    6974
    7075        $redir = wp_get_referer();
    71         if ( add_link() )
     76        if ( add_link() ) {
    7277            $redir = add_query_arg( 'added', 'true', $redir );
     78        }
    7379
    7480        wp_redirect( $redir );
    7581        exit;
    7682
    77     case 'save' :
     83    case 'save':
    7884        $link_id = (int) $_POST['link_id'];
    79         check_admin_referer('update-bookmark_' . $link_id);
     85        check_admin_referer( 'update-bookmark_' . $link_id );
    8086
    81         edit_link($link_id);
     87        edit_link( $link_id );
    8288
    83         wp_redirect($this_file);
     89        wp_redirect( $this_file );
    8490        exit;
    8591
    86     case 'delete' :
     92    case 'delete':
    8793        $link_id = (int) $_GET['link_id'];
    88         check_admin_referer('delete-bookmark_' . $link_id);
     94        check_admin_referer( 'delete-bookmark_' . $link_id );
    8995
    90         wp_delete_link($link_id);
     96        wp_delete_link( $link_id );
    9197
    92         wp_redirect($this_file);
     98        wp_redirect( $this_file );
    9399        exit;
    94100
    95     case 'edit' :
    96         wp_enqueue_script('link');
    97         wp_enqueue_script('xfn');
     101    case 'edit':
     102        wp_enqueue_script( 'link' );
     103        wp_enqueue_script( 'xfn' );
    98104
    99         if ( wp_is_mobile() )
     105        if ( wp_is_mobile() ) {
    100106            wp_enqueue_script( 'jquery-touch-punch' );
     107        }
    101108
    102         $parent_file = 'link-manager.php';
     109        $parent_file  = 'link-manager.php';
    103110        $submenu_file = 'link-manager.php';
    104         $title = __('Edit Link');
     111        $title        = __( 'Edit Link' );
    105112
    106113        $link_id = (int) $_GET['link_id'];
    107114
    108         if (!$link = get_link_to_edit($link_id))
    109             wp_die(__('Link not found.'));
     115        if ( ! $link = get_link_to_edit( $link_id ) ) {
     116            wp_die( __( 'Link not found.' ) );
     117        }
    110118
    111119        include( ABSPATH . 'wp-admin/edit-link-form.php' );
     
    113121        break;
    114122
    115     default :
     123    default:
    116124        break;
    117125}
Note: See TracChangeset for help on using the changeset viewer.