Changeset 42343 for trunk/src/wp-admin/media-new.php

Timestamp:

11/30/2017 11:09:33 PM (7 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-admin/media-new.php (modified) (4 diffs)

trunk/src/wp-admin/media-new.php

@@ -13 +13 @@
 require_once( dirname( __FILE__ ) . '/admin.php' );
 
-if (!current_user_can('upload_files'))
-    wp_die(__('Sorry, you are not allowed to upload files.'));
+if ( ! current_user_can( 'upload_files' ) ) {
+    wp_die( __( 'Sorry, you are not allowed to upload files.' ) );
+}
 
-wp_enqueue_script('plupload-handlers');
+wp_enqueue_script( 'plupload-handlers' );
 
 $post_id = 0;
 if ( isset( $_REQUEST['post_id'] ) ) {
     $post_id = absint( $_REQUEST['post_id'] );
-    if ( ! get_post( $post_id ) || ! current_user_can( 'edit_post', $post_id ) )
+    if ( ! get_post( $post_id ) || ! current_user_can( 'edit_post', $post_id ) ) {
         $post_id = 0;
+    }
 }
 
 if ( $_POST ) {
-    if ( isset($_POST['html-upload']) && !empty($_FILES) ) {
-        check_admin_referer('media-form');
+    if ( isset( $_POST['html-upload'] ) && ! empty( $_FILES ) ) {
+        check_admin_referer( 'media-form' );
         // Upload File button was clicked
         $upload_id = media_handle_upload( 'async-upload', $post_id );
@@ -38 +40 @@
 }
 
-$title = __('Upload New Media');
+$title       = __( 'Upload New Media' );
 $parent_file = 'upload.php';
 
-get_current_screen()->add_help_tab( array(
-'id'        => 'overview',
-'title'     => __('Overview'),
-'content'   =>
-    '<p>' . __('You can upload media files here without creating a post first. This allows you to upload files to use with posts and pages later and/or to get a web link for a particular file that you can share. There are three options for uploading files:') . '</p>' .
-    '<ul>' .
-        '<li>' . __('<strong>Drag and drop</strong> your files into the area below. Multiple files are allowed.') . '</li>' .
-        '<li>' . __('Clicking <strong>Select Files</strong> opens a navigation window showing you files in your operating system. Selecting <strong>Open</strong> after clicking on the file you want activates a progress bar on the uploader screen.') . '</li>' .
-        '<li>' . __('Revert to the <strong>Browser Uploader</strong> by clicking the link below the drag and drop box.') . '</li>' .
-    '</ul>'
-) );
+get_current_screen()->add_help_tab(
+    array(
+        'id'      => 'overview',
+        'title'   => __( 'Overview' ),
+        'content' =>
+                 '<p>' . __( 'You can upload media files here without creating a post first. This allows you to upload files to use with posts and pages later and/or to get a web link for a particular file that you can share. There are three options for uploading files:' ) . '</p>' .
+                 '<ul>' .
+                     '<li>' . __( '<strong>Drag and drop</strong> your files into the area below. Multiple files are allowed.' ) . '</li>' .
+                     '<li>' . __( 'Clicking <strong>Select Files</strong> opens a navigation window showing you files in your operating system. Selecting <strong>Open</strong> after clicking on the file you want activates a progress bar on the uploader screen.' ) . '</li>' .
+                     '<li>' . __( 'Revert to the <strong>Browser Uploader</strong> by clicking the link below the drag and drop box.' ) . '</li>' .
+                 '</ul>',
+    )
+);
 get_current_screen()->set_help_sidebar(
-    '<p><strong>' . __('For more information:') . '</strong></p>' .
-    '<p>' . __('<a href="https://codex.wordpress.org/Media_Add_New_Screen">Documentation on Uploading Media Files</a>') . '</p>' .
-    '<p>' . __('<a href="https://wordpress.org/support/">Support Forums</a>') . '</p>'
+    '<p><strong>' . __( 'For more information:' ) . '</strong></p>' .
+    '<p>' . __( '<a href="https://codex.wordpress.org/Media_Add_New_Screen">Documentation on Uploading Media Files</a>' ) . '</p>' .
+    '<p>' . __( '<a href="https://wordpress.org/support/">Support Forums</a>' ) . '</p>'
 );
 
@@ -62 +66 @@
 $form_class = 'media-upload-form type-form validate';
 
-if ( get_user_setting('uploader') || isset( $_GET['browser-uploader'] ) )
+if ( get_user_setting( 'uploader' ) || isset( $_GET['browser-uploader'] ) ) {
     $form_class .= ' html-uploader';
+}
 ?>
 <div class="wrap">
     <h1><?php echo esc_html( $title ); ?></h1>
 
-    <form enctype="multipart/form-data" method="post" action="<?php echo admin_url('media-new.php'); ?>" class="<?php echo esc_attr( $form_class ); ?>" id="file-form">
+    <form enctype="multipart/form-data" method="post" action="<?php echo admin_url( 'media-new.php' ); ?>" class="<?php echo esc_attr( $form_class ); ?>" id="file-form">
 
     <?php media_upload_form(); ?>
@@ -76 +81 @@
     </script>
     <input type="hidden" name="post_id" id="post_id" value="<?php echo $post_id; ?>" />
-    <?php wp_nonce_field('media-form'); ?>
+    <?php wp_nonce_field( 'media-form' ); ?>
     <div id="media-items" class="hide-if-no-js"></div>
     </form>