Changeset 42343 for trunk/src/wp-admin/media-upload.php

Timestamp:

11/30/2017 11:09:33 PM (7 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-admin/media-upload.php (modified) (6 diffs)

trunk/src/wp-admin/media-upload.php

@@ -10 +10 @@
  */
 
-if ( ! isset( $_GET['inline'] ) )
-    define( 'IFRAME_REQUEST' , true );
+if ( ! isset( $_GET['inline'] ) ) {
+    define( 'IFRAME_REQUEST', true );
+}
 
 /** Load WordPress Administration Bootstrap */
@@ -20 +21 @@
 }
 
-wp_enqueue_script('plupload-handlers');
-wp_enqueue_script('image-edit');
-wp_enqueue_script('set-post-thumbnail' );
-wp_enqueue_style('imgareaselect');
+wp_enqueue_script( 'plupload-handlers' );
+wp_enqueue_script( 'image-edit' );
+wp_enqueue_script( 'set-post-thumbnail' );
+wp_enqueue_style( 'imgareaselect' );
 wp_enqueue_script( 'media-gallery' );
 
-@header('Content-Type: ' . get_option('html_type') . '; charset=' . get_option('blog_charset'));
+@header( 'Content-Type: ' . get_option( 'html_type' ) . '; charset=' . get_option( 'blog_charset' ) );
 
 // IDs should be integers
-$ID = isset($ID) ? (int) $ID : 0;
-$post_id = isset($post_id)? (int) $post_id : 0;
+$ID      = isset( $ID ) ? (int) $ID : 0;
+$post_id = isset( $post_id ) ? (int) $post_id : 0;
 
 // Require an ID for the edit screen.
-if ( isset( $action ) && $action == 'edit' && !$ID ) {
+if ( isset( $action ) && $action == 'edit' && ! $ID ) {
     wp_die(
         '<h1>' . __( 'Cheatin&#8217; uh?' ) . '</h1>' .
@@ -41 +42 @@
 }
 
-if ( ! empty( $_REQUEST['post_id'] ) && ! current_user_can( 'edit_post' , $_REQUEST['post_id'] ) ) {
+if ( ! empty( $_REQUEST['post_id'] ) && ! current_user_can( 'edit_post', $_REQUEST['post_id'] ) ) {
     wp_die(
         '<h1>' . __( 'Cheatin&#8217; uh?' ) . '</h1>' .
@@ -50 +51 @@
 
 // Upload type: image, video, file, ..?
-if ( isset($_GET['type']) ) {
-    $type = strval($_GET['type']);
+if ( isset( $_GET['type'] ) ) {
+    $type = strval( $_GET['type'] );
 } else {
     /**
@@ -65 +66 @@
 
 // Tab: gallery, library, or type-specific.
-if ( isset($_GET['tab']) ) {
-    $tab = strval($_GET['tab']);
+if ( isset( $_GET['tab'] ) ) {
+    $tab = strval( $_GET['tab'] );
 } else {
     /**
@@ -81 +82 @@
 
 // Let the action code decide how to handle the request.
-if ( $tab == 'type' || $tab == 'type_url' || ! array_key_exists( $tab , media_upload_tabs() ) ) {
+if ( $tab == 'type' || $tab == 'type_url' || ! array_key_exists( $tab, media_upload_tabs() ) ) {
     /**
      * Fires inside specific upload-type views in the legacy (pre-3.5.0)