Changeset 42343 for trunk/src/wp-admin/network/site-themes.php

Timestamp:

11/30/2017 11:09:33 PM (8 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-admin/network/site-themes.php (modified) (14 diffs)

trunk/src/wp-admin/network/site-themes.php

@@ -11 +11 @@
 require_once( dirname( __FILE__ ) . '/admin.php' );
 
-if ( ! current_user_can( 'manage_sites' ) )
+if ( ! current_user_can( 'manage_sites' ) ) {
     wp_die( __( 'Sorry, you are not allowed to manage themes for this site.' ) );
+}
 
 get_current_screen()->add_help_tab( get_site_screen_help_tab_args() );
 get_current_screen()->set_help_sidebar( get_site_screen_help_sidebar_content() );
 
-get_current_screen()->set_screen_reader_content( array(
-    'heading_views'      => __( 'Filter site themes list' ),
-    'heading_pagination' => __( 'Site themes list navigation' ),
-    'heading_list'       => __( 'Site themes list' ),
-) );
-
-$wp_list_table = _get_list_table('WP_MS_Themes_List_Table');
+get_current_screen()->set_screen_reader_content(
+    array(
+        'heading_views'      => __( 'Filter site themes list' ),
+        'heading_pagination' => __( 'Site themes list navigation' ),
+        'heading_list'       => __( 'Site themes list' ),
+    )
+);
+
+$wp_list_table = _get_list_table( 'WP_MS_Themes_List_Table' );
 
 $action = $wp_list_table->current_action();
 
-$s = isset($_REQUEST['s']) ? $_REQUEST['s'] : '';
+$s = isset( $_REQUEST['s'] ) ? $_REQUEST['s'] : '';
 
 // Clean up request URI from temporary args for screen options/paging uri's to work as expected.
-$temp_args = array( 'enabled', 'disabled', 'error' );
+$temp_args              = array( 'enabled', 'disabled', 'error' );
 $_SERVER['REQUEST_URI'] = remove_query_arg( $temp_args, $_SERVER['REQUEST_URI'] );
-$referer = remove_query_arg( $temp_args, wp_get_referer() );
+$referer                = remove_query_arg( $temp_args, wp_get_referer() );
 
 if ( ! empty( $_REQUEST['paged'] ) ) {
@@ -40 +43 @@
 $id = isset( $_REQUEST['id'] ) ? intval( $_REQUEST['id'] ) : 0;
 
-if ( ! $id )
-    wp_die( __('Invalid site ID.') );
+if ( ! $id ) {
+    wp_die( __( 'Invalid site ID.' ) );
+}
 
 $wp_list_table->prepare_items();
@@ -50 +54 @@
 }
 
-if ( !can_edit_network( $details->site_id ) )
+if ( ! can_edit_network( $details->site_id ) ) {
     wp_die( __( 'Sorry, you are not allowed to access this page.' ), 403 );
+}
 
 $is_main_site = is_main_site( $id );
@@ -62 +67 @@
         case 'enable':
             check_admin_referer( 'enable-theme_' . $_GET['theme'] );
-            $theme = $_GET['theme'];
+            $theme  = $_GET['theme'];
             $action = 'enabled';
-            $n = 1;
-            if ( !$allowed_themes )
+            $n      = 1;
+            if ( ! $allowed_themes ) {
                 $allowed_themes = array( $theme => true );
-            else
-                $allowed_themes[$theme] = true;
+            } else {
+                $allowed_themes[ $theme ] = true;
+            }
             break;
         case 'disable':
             check_admin_referer( 'disable-theme_' . $_GET['theme'] );
-            $theme = $_GET['theme'];
+            $theme  = $_GET['theme'];
             $action = 'disabled';
-            $n = 1;
-            if ( !$allowed_themes )
+            $n      = 1;
+            if ( ! $allowed_themes ) {
                 $allowed_themes = array();
-            else
-                unset( $allowed_themes[$theme] );
+            } else {
+                unset( $allowed_themes[ $theme ] );
+            }
             break;
         case 'enable-selected':
@@ -85 +92 @@
                 $themes = (array) $_POST['checked'];
                 $action = 'enabled';
-                $n = count( $themes );
-                foreach ( (array) $themes as $theme )
+                $n      = count( $themes );
+                foreach ( (array) $themes as $theme ) {
                     $allowed_themes[ $theme ] = true;
+                }
             } else {
                 $action = 'error';
-                $n = 'none';
+                $n      = 'none';
             }
             break;
@@ -98 +106 @@
                 $themes = (array) $_POST['checked'];
                 $action = 'disabled';
-                $n = count( $themes );
-                foreach ( (array) $themes as $theme )
+                $n      = count( $themes );
+                foreach ( (array) $themes as $theme ) {
                     unset( $allowed_themes[ $theme ] );
+                }
             } else {
                 $action = 'error';
-                $n = 'none';
+                $n      = 'none';
             }
             break;
@@ -110 +119 @@
                 check_admin_referer( 'bulk-themes' );
                 $themes = (array) $_POST['checked'];
-                $n = count( $themes );
+                $n      = count( $themes );
                 $screen = get_current_screen()->id;
 
@@ -131 +140 @@
             } else {
                 $action = 'error';
-                $n = 'none';
+                $n      = 'none';
             }
     }
@@ -138 +147 @@
     restore_current_blog();
 
-    wp_safe_redirect( add_query_arg( array( 'id' => $id, $action => $n ), $referer ) );
+    wp_safe_redirect(
+        add_query_arg(
+            array(
+                'id'    => $id,
+                $action => $n,
+            ), $referer
+        )
+    );
     exit;
 }
@@ -153 +169 @@
 $title = sprintf( __( 'Edit Site: %s' ), esc_html( $details->blogname ) );
 
-$parent_file = 'sites.php';
+$parent_file  = 'sites.php';
 $submenu_file = 'sites.php';
 
@@ -163 +179 @@
 <?php
 
-network_edit_site_nav( array(
-    'blog_id'  => $id,
-    'selected' => 'site-themes'
-) );
+network_edit_site_nav(
+    array(
+        'blog_id'  => $id,
+        'selected' => 'site-themes',
+    )
+);
 
 if ( isset( $_GET['enabled'] ) ) {
@@ -186 +204 @@
 } elseif ( isset( $_GET['error'] ) && 'none' == $_GET['error'] ) {
     echo '<div id="message" class="error notice is-dismissible"><p>' . __( 'No theme selected.' ) . '</p></div>';
-} ?>
-
-<p><?php _e( 'Network enabled themes are not shown on this screen.' ) ?></p>
+}
+?>
+
+<p><?php _e( 'Network enabled themes are not shown on this screen.' ); ?></p>
 
 <form method="get">
 <?php $wp_list_table->search_box( __( 'Search Installed Themes' ), 'theme' ); ?>
-<input type="hidden" name="id" value="<?php echo esc_attr( $id ) ?>" />
+<input type="hidden" name="id" value="<?php echo esc_attr( $id ); ?>" />
 </form>
 
@@ -198 +217 @@
 
 <form method="post" action="site-themes.php?action=update-site">
-    <input type="hidden" name="id" value="<?php echo esc_attr( $id ) ?>" />
+    <input type="hidden" name="id" value="<?php echo esc_attr( $id ); ?>" />
 
 <?php $wp_list_table->display(); ?>
@@ -205 +224 @@
 
 </div>
-<?php include(ABSPATH . 'wp-admin/admin-footer.php'); ?>
+<?php include( ABSPATH . 'wp-admin/admin-footer.php' ); ?>