Changeset 42343 for trunk/src/wp-admin/network/users.php

Timestamp:

11/30/2017 11:09:33 PM (6 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-admin/network/users.php (modified) (10 diffs)

trunk/src/wp-admin/network/users.php

@@ -11 +11 @@
 require_once( dirname( __FILE__ ) . '/admin.php' );
 
-if ( ! current_user_can( 'manage_network_users' ) )
+if ( ! current_user_can( 'manage_network_users' ) ) {
     wp_die( __( 'Sorry, you are not allowed to access this page.' ), 403 );
+}
 
 if ( isset( $_GET['action'] ) ) {
@@ -20 +21 @@
     switch ( $_GET['action'] ) {
         case 'deleteuser':
-            if ( ! current_user_can( 'manage_network_users' ) )
+            if ( ! current_user_can( 'manage_network_users' ) ) {
                 wp_die( __( 'Sorry, you are not allowed to access this page.' ), 403 );
+            }
 
             check_admin_referer( 'deleteuser' );
@@ -28 +30 @@
             if ( $id != '0' && $id != '1' ) {
                 $_POST['allusers'] = array( $id ); // confirm_delete_users() can only handle with arrays
-                $title = __( 'Users' );
-                $parent_file = 'users.php';
+                $title             = __( 'Users' );
+                $parent_file       = 'users.php';
                 require_once( ABSPATH . 'wp-admin/admin-header.php' );
                 echo '<div class="wrap">';
@@ -41 +43 @@
 
         case 'allusers':
-            if ( !current_user_can( 'manage_network_users' ) )
+            if ( ! current_user_can( 'manage_network_users' ) ) {
                 wp_die( __( 'Sorry, you are not allowed to access this page.' ), 403 );
-
-            if ( ( isset( $_POST['action']) || isset($_POST['action2'] ) ) && isset( $_POST['allusers'] ) ) {
+            }
+
+            if ( ( isset( $_POST['action'] ) || isset( $_POST['action2'] ) ) && isset( $_POST['allusers'] ) ) {
                 check_admin_referer( 'bulk-users-network' );
 
-                $doaction = $_POST['action'] != -1 ? $_POST['action'] : $_POST['action2'];
+                $doaction     = $_POST['action'] != -1 ? $_POST['action'] : $_POST['action2'];
                 $userfunction = '';
 
                 foreach ( (array) $_POST['allusers'] as $user_id ) {
-                    if ( !empty( $user_id ) ) {
+                    if ( ! empty( $user_id ) ) {
                         switch ( $doaction ) {
                             case 'delete':
-                                if ( ! current_user_can( 'delete_users' ) )
+                                if ( ! current_user_can( 'delete_users' ) ) {
                                     wp_die( __( 'Sorry, you are not allowed to access this page.' ), 403 );
-                                $title = __( 'Users' );
+                                }
+                                $title       = __( 'Users' );
                                 $parent_file = 'users.php';
                                 require_once( ABSPATH . 'wp-admin/admin-header.php' );
@@ -67 +71 @@
                             case 'spam':
                                 $user = get_userdata( $user_id );
-                                if ( is_super_admin( $user->ID ) )
+                                if ( is_super_admin( $user->ID ) ) {
                                     wp_die( sprintf( __( 'Warning! User cannot be modified. The user %s is a network administrator.' ), esc_html( $user->user_login ) ) );
+                                }
 
                                 $userfunction = 'all_spam';
-                                $blogs = get_blogs_of_user( $user_id, true );
+                                $blogs        = get_blogs_of_user( $user_id, true );
                                 foreach ( (array) $blogs as $details ) {
-                                    if ( $details->userblog_id != get_network()->site_id ) // main blog not a spam !
+                                    if ( $details->userblog_id != get_network()->site_id ) { // main blog not a spam !
                                         update_blog_status( $details->userblog_id, 'spam', '1' );
+                                    }
                                 }
                                 update_user_status( $user_id, 'spam', '1' );
-                            break;
+                                break;
 
                             case 'notspam':
                                 $userfunction = 'all_notspam';
-                                $blogs = get_blogs_of_user( $user_id, true );
-                                foreach ( (array) $blogs as $details )
+                                $blogs        = get_blogs_of_user( $user_id, true );
+                                foreach ( (array) $blogs as $details ) {
                                     update_blog_status( $details->userblog_id, 'spam', '0' );
+                                }
 
                                 update_user_status( $user_id, 'spam', '0' );
-                            break;
+                                break;
                         }
                     }
@@ -102 +109 @@
                 }
 
-                wp_safe_redirect( add_query_arg( array( 'updated' => 'true', 'action' => $userfunction ), wp_get_referer() ) );
+                wp_safe_redirect(
+                    add_query_arg(
+                        array(
+                            'updated' => 'true',
+                            'action'  => $userfunction,
+                        ), wp_get_referer()
+                    )
+                );
             } else {
                 $location = network_admin_url( 'users.php' );
 
-                if ( ! empty( $_REQUEST['paged'] ) )
+                if ( ! empty( $_REQUEST['paged'] ) ) {
                     $location = add_query_arg( 'paged', (int) $_REQUEST['paged'], $location );
+                }
                 wp_redirect( $location );
             }
@@ -114 +129 @@
         case 'dodelete':
             check_admin_referer( 'ms-users-delete' );
-            if ( ! ( current_user_can( 'manage_network_users' ) && current_user_can( 'delete_users' ) ) )
+            if ( ! ( current_user_can( 'manage_network_users' ) && current_user_can( 'delete_users' ) ) ) {
                 wp_die( __( 'Sorry, you are not allowed to access this page.' ), 403 );
+            }
 
             if ( ! empty( $_POST['blog'] ) && is_array( $_POST['blog'] ) ) {
                 foreach ( $_POST['blog'] as $id => $users ) {
                     foreach ( $users as $blogid => $user_id ) {
-                        if ( ! current_user_can( 'delete_user', $id ) )
+                        if ( ! current_user_can( 'delete_user', $id ) ) {
                             continue;
-
-                        if ( ! empty( $_POST['delete'] ) && 'reassign' == $_POST['delete'][$blogid][$id] )
+                        }
+
+                        if ( ! empty( $_POST['delete'] ) && 'reassign' == $_POST['delete'][ $blogid ][ $id ] ) {
                             remove_user_from_blog( $id, $blogid, $user_id );
-                        else
+                        } else {
                             remove_user_from_blog( $id, $blogid );
+                        }
                     }
                 }
             }
             $i = 0;
-            if ( is_array( $_POST['user'] ) && ! empty( $_POST['user'] ) )
+            if ( is_array( $_POST['user'] ) && ! empty( $_POST['user'] ) ) {
                 foreach ( $_POST['user'] as $id ) {
-                    if ( ! current_user_can( 'delete_user', $id ) )
+                    if ( ! current_user_can( 'delete_user', $id ) ) {
                         continue;
+                    }
                     wpmu_delete_user( $id );
                     $i++;
                 }
-
-            if ( $i == 1 )
+            }
+
+            if ( $i == 1 ) {
                 $deletefunction = 'delete';
-            else
+            } else {
                 $deletefunction = 'all_delete';
-
-            wp_redirect( add_query_arg( array( 'updated' => 'true', 'action' => $deletefunction ), network_admin_url( 'users.php' ) ) );
+            }
+
+            wp_redirect(
+                add_query_arg(
+                    array(
+                        'updated' => 'true',
+                        'action'  => $deletefunction,
+                    ), network_admin_url( 'users.php' )
+                )
+            );
             exit();
     }
 }
 
-$wp_list_table = _get_list_table('WP_MS_Users_List_Table');
-$pagenum = $wp_list_table->get_pagenum();
+$wp_list_table = _get_list_table( 'WP_MS_Users_List_Table' );
+$pagenum       = $wp_list_table->get_pagenum();
 $wp_list_table->prepare_items();
 $total_pages = $wp_list_table->get_pagination_arg( 'total_pages' );
@@ -158 +186 @@
     exit;
 }
-$title = __( 'Users' );
+$title       = __( 'Users' );
 $parent_file = 'users.php';
 
 add_screen_option( 'per_page' );
 
-get_current_screen()->add_help_tab( array(
-    'id'      => 'overview',
-    'title'   => __('Overview'),
-    'content' =>
-        '<p>' . __('This table shows all users across the network and the sites to which they are assigned.') . '</p>' .
-        '<p>' . __('Hover over any user on the list to make the edit links appear. The Edit link on the left will take you to their Edit User profile page; the Edit link on the right by any site name goes to an Edit Site screen for that site.') . '</p>' .
-        '<p>' . __('You can also go to the user&#8217;s profile page by clicking on the individual username.') . '</p>' .
-        '<p>' . __( 'You can sort the table by clicking on any of the table headings and switch between list and excerpt views by using the icons above the users list.' ) . '</p>' .
-        '<p>' . __('The bulk action will permanently delete selected users, or mark/unmark those selected as spam. Spam users will have posts removed and will be unable to sign up again with the same email addresses.') . '</p>' .
-        '<p>' . __('You can make an existing user an additional super admin by going to the Edit User profile page and checking the box to grant that privilege.') . '</p>'
-) );
+get_current_screen()->add_help_tab(
+    array(
+        'id'      => 'overview',
+        'title'   => __( 'Overview' ),
+        'content' =>
+            '<p>' . __( 'This table shows all users across the network and the sites to which they are assigned.' ) . '</p>' .
+            '<p>' . __( 'Hover over any user on the list to make the edit links appear. The Edit link on the left will take you to their Edit User profile page; the Edit link on the right by any site name goes to an Edit Site screen for that site.' ) . '</p>' .
+            '<p>' . __( 'You can also go to the user&#8217;s profile page by clicking on the individual username.' ) . '</p>' .
+            '<p>' . __( 'You can sort the table by clicking on any of the table headings and switch between list and excerpt views by using the icons above the users list.' ) . '</p>' .
+            '<p>' . __( 'The bulk action will permanently delete selected users, or mark/unmark those selected as spam. Spam users will have posts removed and will be unable to sign up again with the same email addresses.' ) . '</p>' .
+            '<p>' . __( 'You can make an existing user an additional super admin by going to the Edit User profile page and checking the box to grant that privilege.' ) . '</p>',
+    )
+);
 
 get_current_screen()->set_help_sidebar(
-    '<p><strong>' . __('For more information:') . '</strong></p>' .
-    '<p>' . __('<a href="https://codex.wordpress.org/Network_Admin_Users_Screen">Documentation on Network Users</a>') . '</p>' .
-    '<p>' . __('<a href="https://wordpress.org/support/forum/multisite/">Support Forums</a>') . '</p>'
+    '<p><strong>' . __( 'For more information:' ) . '</strong></p>' .
+    '<p>' . __( '<a href="https://codex.wordpress.org/Network_Admin_Users_Screen">Documentation on Network Users</a>' ) . '</p>' .
+    '<p>' . __( '<a href="https://wordpress.org/support/forum/multisite/">Support Forums</a>' ) . '</p>'
 );
 
-get_current_screen()->set_screen_reader_content( array(
-    'heading_views'      => __( 'Filter users list' ),
-    'heading_pagination' => __( 'Users list navigation' ),
-    'heading_list'       => __( 'Users list' ),
-) );
+get_current_screen()->set_screen_reader_content(
+    array(
+        'heading_views'      => __( 'Filter users list' ),
+        'heading_pagination' => __( 'Users list navigation' ),
+        'heading_list'       => __( 'Users list' ),
+    )
+);
 
 require_once( ABSPATH . 'wp-admin/admin-header.php' );
@@ -196 +228 @@
             case 'delete':
                 _e( 'User deleted.' );
-            break;
+                break;
             case 'all_spam':
                 _e( 'Users marked as spam.' );
-            break;
+                break;
             case 'all_notspam':
                 _e( 'Users removed from spam.' );
-            break;
+                break;
             case 'all_delete':
                 _e( 'Users deleted.' );
-            break;
+                break;
             case 'add':
                 _e( 'User added.' );
-            break;
+                break;
         }
         ?>
@@ -219 +251 @@
 
     <?php
-    if ( current_user_can( 'create_users') ) : ?>
-        <a href="<?php echo network_admin_url('user-new.php'); ?>" class="page-title-action"><?php echo esc_html_x( 'Add New', 'user' ); ?></a><?php
+    if ( current_user_can( 'create_users' ) ) :
+    ?>
+        <a href="<?php echo network_admin_url( 'user-new.php' ); ?>" class="page-title-action"><?php echo esc_html_x( 'Add New', 'user' ); ?></a>
+                            <?php
     endif;