Changeset 42343 for trunk/src/wp-content/themes/twentyfourteen/inc/featured-content.php

Timestamp:

11/30/2017 11:09:33 PM (7 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-content/themes/twentyfourteen/inc/featured-content.php (modified) (6 diffs)

trunk/src/wp-content/themes/twentyfourteen/inc/featured-content.php

@@ -84 +84 @@
         }
 
-        add_filter( $filter,                              array( __CLASS__, 'get_featured_posts' )    );
-        add_action( 'customize_register',                 array( __CLASS__, 'customize_register' ), 9 );
-        add_action( 'admin_init',                         array( __CLASS__, 'register_setting'   )    );
-        add_action( 'switch_theme',                       array( __CLASS__, 'delete_transient'   )    );
-        add_action( 'save_post',                          array( __CLASS__, 'delete_transient'   )    );
-        add_action( 'delete_post_tag',                    array( __CLASS__, 'delete_post_tag'    )    );
-        add_action( 'customize_controls_enqueue_scripts', array( __CLASS__, 'enqueue_scripts'    )    );
-        add_action( 'pre_get_posts',                      array( __CLASS__, 'pre_get_posts'      )    );
-        add_action( 'wp_loaded',                          array( __CLASS__, 'wp_loaded'          )    );
+        add_filter( $filter, array( __CLASS__, 'get_featured_posts' ) );
+        add_action( 'customize_register', array( __CLASS__, 'customize_register' ), 9 );
+        add_action( 'admin_init', array( __CLASS__, 'register_setting' ) );
+        add_action( 'switch_theme', array( __CLASS__, 'delete_transient' ) );
+        add_action( 'save_post', array( __CLASS__, 'delete_transient' ) );
+        add_action( 'delete_post_tag', array( __CLASS__, 'delete_post_tag' ) );
+        add_action( 'customize_controls_enqueue_scripts', array( __CLASS__, 'enqueue_scripts' ) );
+        add_action( 'pre_get_posts', array( __CLASS__, 'pre_get_posts' ) );
+        add_action( 'wp_loaded', array( __CLASS__, 'wp_loaded' ) );
     }
 
@@ -107 +107 @@
     public static function wp_loaded() {
         if ( self::get_setting( 'hide-tag' ) ) {
-            add_filter( 'get_terms',     array( __CLASS__, 'hide_featured_term'     ), 10, 3 );
+            add_filter( 'get_terms', array( __CLASS__, 'hide_featured_term' ), 10, 3 );
             add_filter( 'get_the_terms', array( __CLASS__, 'hide_the_featured_term' ), 10, 3 );
         }
@@ -129 +129 @@
         }
 
-        $featured_posts = get_posts( array(
-            'include'        => $post_ids,
-            'posts_per_page' => count( $post_ids ),
-        ) );
+        $featured_posts = get_posts(
+            array(
+                'include'        => $post_ids,
+                'posts_per_page' => count( $post_ids ),
+            )
+        );
 
         return $featured_posts;
@@ -161 +163 @@
             if ( $term ) {
                 // Query for featured posts.
-                $featured_ids = get_posts( array(
-                    'fields'           => 'ids',
-                    'numberposts'      => self::$max_posts,
-                    'suppress_filters' => false,
-                    'tax_query'        => array(
-                        array(
-                            'field'    => 'term_id',
-                            'taxonomy' => 'post_tag',
-                            'terms'    => $term->term_id,
+                $featured_ids = get_posts(
+                    array(
+                        'fields'           => 'ids',
+                        'numberposts'      => self::$max_posts,
+                        'suppress_filters' => false,
+                        'tax_query'        => array(
+                            array(
+                                'field'    => 'term_id',
+                                'taxonomy' => 'post_tag',
+                                'terms'    => $term->term_id,
+                            ),
                         ),
-                    ),
-                ) );
+                    )
+                );
             }
 
@@ -284 +288 @@
 
         $settings['tag-id'] = 0;
-        $settings = self::validate_settings( $settings );
+        $settings           = self::validate_settings( $settings );
         update_option( 'featured-content', $settings );
     }
@@ -400 +404 @@
      */
     public static function customize_register( $wp_customize ) {
-        $wp_customize->add_section( 'featured_content', array(
-            'title'          => __( 'Featured Content', 'twentyfourteen' ),
-            'description'    => sprintf( __( 'Use a <a href="%1$s">tag</a> to feature your posts. If no posts match the tag, <a href="%2$s">sticky posts</a> will be displayed instead.', 'twentyfourteen' ),
-                esc_url( add_query_arg( 'tag', _x( 'featured', 'featured content default tag slug', 'twentyfourteen' ), admin_url( 'edit.php' ) ) ),
-                admin_url( 'edit.php?show_sticky=1' )
-            ),
-            'priority'       => 130,
-            'theme_supports' => 'featured-content',
-        ) );
+        $wp_customize->add_section(
+            'featured_content', array(
+                'title'          => __( 'Featured Content', 'twentyfourteen' ),
+                'description'    => sprintf(
+                    __( 'Use a <a href="%1$s">tag</a> to feature your posts. If no posts match the tag, <a href="%2$s">sticky posts</a> will be displayed instead.', 'twentyfourteen' ),
+                    esc_url( add_query_arg( 'tag', _x( 'featured', 'featured content default tag slug', 'twentyfourteen' ), admin_url( 'edit.php' ) ) ),
+                    admin_url( 'edit.php?show_sticky=1' )
+                ),
+                'priority'       => 130,
+                'theme_supports' => 'featured-content',
+            )
+        );
 
         // Add Featured Content settings.
-        $wp_customize->add_setting( 'featured-content[tag-name]', array(
-            'default'              => _x( 'featured', 'featured content default tag slug', 'twentyfourteen' ),
-            'type'                 => 'option',
-            'sanitize_js_callback' => array( __CLASS__, 'delete_transient' ),
-        ) );
-        $wp_customize->add_setting( 'featured-content[hide-tag]', array(
-            'default'              => true,
-            'type'                 => 'option',
-            'sanitize_js_callback' => array( __CLASS__, 'delete_transient' ),
-        ) );
+        $wp_customize->add_setting(
+            'featured-content[tag-name]', array(
+                'default'              => _x( 'featured', 'featured content default tag slug', 'twentyfourteen' ),
+                'type'                 => 'option',
+                'sanitize_js_callback' => array( __CLASS__, 'delete_transient' ),
+            )
+        );
+        $wp_customize->add_setting(
+            'featured-content[hide-tag]', array(
+                'default'              => true,
+                'type'                 => 'option',
+                'sanitize_js_callback' => array( __CLASS__, 'delete_transient' ),
+            )
+        );
 
         // Add Featured Content controls.
-        $wp_customize->add_control( 'featured-content[tag-name]', array(
-            'label'    => __( 'Tag Name', 'twentyfourteen' ),
-            'section'  => 'featured_content',
-            'priority' => 20,
-        ) );
-        $wp_customize->add_control( 'featured-content[hide-tag]', array(
-            'label'    => __( 'Don&rsquo;t display tag on front end.', 'twentyfourteen' ),
-            'section'  => 'featured_content',
-            'type'     => 'checkbox',
-            'priority' => 30,
-        ) );
+        $wp_customize->add_control(
+            'featured-content[tag-name]', array(
+                'label'    => __( 'Tag Name', 'twentyfourteen' ),
+                'section'  => 'featured_content',
+                'priority' => 20,
+            )
+        );
+        $wp_customize->add_control(
+            'featured-content[hide-tag]', array(
+                'label'    => __( 'Don&rsquo;t display tag on front end.', 'twentyfourteen' ),
+                'section'  => 'featured_content',
+                'type'     => 'checkbox',
+                'priority' => 30,
+            )
+        );
     }