Changeset 42343 for trunk/src/wp-content/themes/twentythirteen/inc/custom-header.php

Timestamp:

11/30/2017 11:09:33 PM (7 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-content/themes/twentythirteen/inc/custom-header.php (modified) (6 diffs)

trunk/src/wp-content/themes/twentythirteen/inc/custom-header.php

@@ -43 +43 @@
      * %s is a placeholder for the theme template directory URI.
      */
-    register_default_headers( array(
-        'circle' => array(
-            'url'           => '%s/images/headers/circle.png',
-            'thumbnail_url' => '%s/images/headers/circle-thumbnail.png',
-            'description'   => _x( 'Circle', 'header image description', 'twentythirteen' )
-        ),
-        'diamond' => array(
-            'url'           => '%s/images/headers/diamond.png',
-            'thumbnail_url' => '%s/images/headers/diamond-thumbnail.png',
-            'description'   => _x( 'Diamond', 'header image description', 'twentythirteen' )
-        ),
-        'star' => array(
-            'url'           => '%s/images/headers/star.png',
-            'thumbnail_url' => '%s/images/headers/star-thumbnail.png',
-            'description'   => _x( 'Star', 'header image description', 'twentythirteen' )
-        ),
-    ) );
+    register_default_headers(
+        array(
+            'circle'  => array(
+                'url'           => '%s/images/headers/circle.png',
+                'thumbnail_url' => '%s/images/headers/circle-thumbnail.png',
+                'description'   => _x( 'Circle', 'header image description', 'twentythirteen' ),
+            ),
+            'diamond' => array(
+                'url'           => '%s/images/headers/diamond.png',
+                'thumbnail_url' => '%s/images/headers/diamond-thumbnail.png',
+                'description'   => _x( 'Diamond', 'header image description', 'twentythirteen' ),
+            ),
+            'star'    => array(
+                'url'           => '%s/images/headers/star.png',
+                'thumbnail_url' => '%s/images/headers/star-thumbnail.png',
+                'description'   => _x( 'Star', 'header image description', 'twentythirteen' ),
+            ),
+        )
+    );
 }
 add_action( 'after_setup_theme', 'twentythirteen_custom_header_setup', 11 );
@@ -89 +91 @@
 
     // If no custom options for text are set, let's bail.
-    if ( empty( $header_image ) && $text_color == get_theme_support( 'custom-header', 'default-text-color' ) )
+    if ( empty( $header_image ) && $text_color == get_theme_support( 'custom-header', 'default-text-color' ) ) {
         return;
+    }
 
     // If we get this far, we have custom styles.
@@ -96 +99 @@
     <style type="text/css" id="twentythirteen-header-css">
     <?php
-        if ( ! empty( $header_image ) ) :
-    ?>
+    if ( ! empty( $header_image ) ) :
+    ?>
+    .site-header {
+        background: url(<?php header_image(); ?>) no-repeat scroll top;
+        background-size: 1600px auto;
+    }
+    @media (max-width: 767px) {
         .site-header {
-            background: url(<?php header_image(); ?>) no-repeat scroll top;
-            background-size: 1600px auto;
-        }
-        @media (max-width: 767px) {
-            .site-header {
-                background-size: 768px auto;
-            }
-        }
-        @media (max-width: 359px) {
-            .site-header {
-                background-size: 360px auto;
-            }
-        }
+            background-size: 768px auto;
+        }
+    }
+    @media (max-width: 359px) {
+        .site-header {
+            background-size: 360px auto;
+        }
+    }
     <?php
         endif;
 
         // Has the text been hidden?
-        if ( ! display_header_text() ) :
-    ?>
-        .site-title,
-        .site-description {
-            position: absolute;
-            clip: rect(1px 1px 1px 1px); /* IE7 */
-            clip: rect(1px, 1px, 1px, 1px);
-        }
-    <?php
-            if ( empty( $header_image ) ) :
-    ?>
-        .site-header .home-link {
-            min-height: 0;
-        }
-    <?php
-            endif;
+    if ( ! display_header_text() ) :
+    ?>
+    .site-title,
+    .site-description {
+        position: absolute;
+        clip: rect(1px 1px 1px 1px); /* IE7 */
+        clip: rect(1px, 1px, 1px, 1px);
+    }
+    <?php
+    if ( empty( $header_image ) ) :
+    ?>
+    .site-header .home-link {
+    min-height: 0;
+    }
+    <?php
+        endif;
 
         // If the user has set a custom color for the text, use that.
@@ -162 +165 @@
         if ( ! empty( $header_image ) ) {
             echo 'background: url(' . esc_url( $header_image ) . ') no-repeat scroll top; background-size: 1600px auto;';
-        } ?>
+        }
+        ?>
         padding: 0 20px;
     }
@@ -174 +178 @@
         if ( ! empty( $header_image ) || display_header_text() ) {
             echo 'min-height: 230px;';
-        } ?>
+        }
+        ?>
         width: 100%;
     }
@@ -228 +233 @@
         </div>
     </div>
-<?php }
+<?php
+}