Changeset 42343 for trunk/src/wp-content/themes/twentytwelve/image.php

Timestamp:

11/30/2017 11:09:33 PM (8 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-content/themes/twentytwelve/image.php (modified) (5 diffs)

trunk/src/wp-content/themes/twentytwelve/image.php

@@ -15 +15 @@
         <div id="content" role="main">
 
-        <?php while ( have_posts() ) : the_post(); ?>
+        <?php
+        while ( have_posts() ) :
+            the_post();
+?>
 
                 <article id="post-<?php the_ID(); ?>" <?php post_class( 'image-attachment' ); ?>>
@@ -24 +27 @@
                             <?php
                                 $metadata = wp_get_attachment_metadata();
-                                printf( __( '<span class="meta-prep meta-prep-entry-date">Published </span> <span class="entry-date"><time class="entry-date" datetime="%1$s">%2$s</time></span> at <a href="%3$s" title="Link to full-size image">%4$s &times; %5$s</a> in <a href="%6$s" title="Return to %7$s" rel="gallery">%8$s</a>.', 'twentytwelve' ),
+                                printf(
+                                    __( '<span class="meta-prep meta-prep-entry-date">Published </span> <span class="entry-date"><time class="entry-date" datetime="%1$s">%2$s</time></span> at <a href="%3$s" title="Link to full-size image">%4$s &times; %5$s</a> in <a href="%6$s" title="Return to %7$s" rel="gallery">%8$s</a>.', 'twentytwelve' ),
                                     esc_attr( get_the_date( 'c' ) ),
                                     esc_html( get_the_date() ),
@@ -53 +57 @@
  * or the first image (if we're looking at the last image in a gallery), or, in a gallery of one, just the link to that image file
  */
-$attachments = array_values( get_children( array( 'post_parent' => $post->post_parent, 'post_status' => 'inherit', 'post_type' => 'attachment', 'post_mime_type' => 'image', 'order' => 'ASC', 'orderby' => 'menu_order ID' ) ) );
+$attachments = array_values(
+    get_children(
+        array(
+            'post_parent'    => $post->post_parent,
+            'post_status'    => 'inherit',
+            'post_type'      => 'attachment',
+            'post_mime_type' => 'image',
+            'order'          => 'ASC',
+            'orderby'        => 'menu_order ID',
+        )
+    )
+);
 foreach ( $attachments as $k => $attachment ) :
-    if ( $attachment->ID == $post->ID )
+    if ( $attachment->ID == $post->ID ) {
         break;
+    }
 endforeach;
 
@@ -74 +90 @@
 endif;
 ?>
-                                <a href="<?php echo esc_url( $next_attachment_url ); ?>" title="<?php the_title_attribute(); ?>" rel="attachment"><?php
-                                /**
-                                 * Filter the image attachment size to use.
-                                 *
-                                 * @since Twenty Twelve 1.0
-                                 *
-                                 * @param array $size {
-                                 *     @type int The attachment height in pixels.
-                                 *     @type int The attachment width in pixels.
-                                 * }
-                                 */
-                                $attachment_size = apply_filters( 'twentytwelve_attachment_size', array( 960, 960 ) );
-                                echo wp_get_attachment_image( $post->ID, $attachment_size );
-                                ?></a>
+                                <a href="<?php echo esc_url( $next_attachment_url ); ?>" title="<?php the_title_attribute(); ?>" rel="attachment">
+                                                    <?php
+                                                    /**
+                                                     * Filter the image attachment size to use.
+                                                     *
+                                                     * @since Twenty Twelve 1.0
+                                                     *
+                                                     * @param array $size {
+                                                     *     @type int The attachment height in pixels.
+                                                     *     @type int The attachment width in pixels.
+                                                     * }
+                                                     */
+                                                    $attachment_size = apply_filters( 'twentytwelve_attachment_size', array( 960, 960 ) );
+                                                    echo wp_get_attachment_image( $post->ID, $attachment_size );
+                                ?>
+                                </a>
 
                                 <?php if ( ! empty( $post->post_excerpt ) ) : ?>
@@ -100 +118 @@
                         <div class="entry-description">
                             <?php the_content(); ?>
-                            <?php wp_link_pages( array( 'before' => '<div class="page-links">' . __( 'Pages:', 'twentytwelve' ), 'after' => '</div>' ) ); ?>
+                            <?php
+                            wp_link_pages(
+                                array(
+                                    'before' => '<div class="page-links">' . __( 'Pages:', 'twentytwelve' ),
+                                    'after'  => '</div>',
+                                )
+                            );
+?>
                         </div><!-- .entry-description -->