Changeset 42343 for trunk/src/wp-includes/class-walker-nav-menu.php

Timestamp:

11/30/2017 11:09:33 PM (8 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-includes/class-walker-nav-menu.php (modified) (6 diffs)

trunk/src/wp-includes/class-walker-nav-menu.php

@@ -35 +35 @@
      * @see Walker::$db_fields
      */
-    public $db_fields = array( 'parent' => 'menu_item_parent', 'id' => 'db_id' );
+    public $db_fields = array(
+        'parent' => 'menu_item_parent',
+        'id'     => 'db_id',
+    );
 
     /**
@@ -95 +98 @@
             $n = "\n";
         }
-        $indent = str_repeat( $t, $depth );
+        $indent  = str_repeat( $t, $depth );
         $output .= "$indent</ul>{$n}";
     }
@@ -123 +126 @@
         $indent = ( $depth ) ? str_repeat( $t, $depth ) : '';
 
-        $classes = empty( $item->classes ) ? array() : (array) $item->classes;
+        $classes   = empty( $item->classes ) ? array() : (array) $item->classes;
         $classes[] = 'menu-item-' . $item->ID;
 
@@ -162 +165 @@
          * @param int      $depth   Depth of menu item. Used for padding.
          */
-        $id = apply_filters( 'nav_menu_item_id', 'menu-item-'. $item->ID, $item, $args, $depth );
+        $id = apply_filters( 'nav_menu_item_id', 'menu-item-' . $item->ID, $item, $args, $depth );
         $id = $id ? ' id="' . esc_attr( $id ) . '"' : '';
 
-        $output .= $indent . '<li' . $id . $class_names .'>';
-
-        $atts = array();
+        $output .= $indent . '<li' . $id . $class_names . '>';
+
+        $atts           = array();
         $atts['title']  = ! empty( $item->attr_title ) ? $item->attr_title : '';
-        $atts['target'] = ! empty( $item->target )     ? $item->target     : '';
-        $atts['rel']    = ! empty( $item->xfn )        ? $item->xfn        : '';
-        $atts['href']   = ! empty( $item->url )        ? $item->url        : '';
+        $atts['target'] = ! empty( $item->target ) ? $item->target : '';
+        $atts['rel']    = ! empty( $item->xfn ) ? $item->xfn : '';
+        $atts['href']   = ! empty( $item->url ) ? $item->url : '';
 
         /**
@@ -196 +199 @@
         foreach ( $atts as $attr => $value ) {
             if ( ! empty( $value ) ) {
-                $value = ( 'href' === $attr ) ? esc_url( $value ) : esc_attr( $value );
+                $value       = ( 'href' === $attr ) ? esc_url( $value ) : esc_attr( $value );
                 $attributes .= ' ' . $attr . '="' . $value . '"';
             }
@@ -216 +219 @@
         $title = apply_filters( 'nav_menu_item_title', $title, $item, $args, $depth );
 
-        $item_output = $args->before;
-        $item_output .= '<a'. $attributes .'>';
+        $item_output  = $args->before;
+        $item_output .= '<a' . $attributes . '>';
         $item_output .= $args->link_before . $title . $args->link_after;
         $item_output .= '</a>';