Changeset 42343 for trunk/src/wp-includes/class-wp-http-ixr-client.php

Timestamp:

11/30/2017 11:09:33 PM (8 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-includes/class-wp-http-ixr-client.php (modified) (8 diffs)

trunk/src/wp-includes/class-wp-http-ixr-client.php

@@ -5 +5 @@
  * @package WordPress
  * @since 3.1.0
- *
  */
 class WP_HTTP_IXR_Client extends IXR_Client {
@@ -20 +19 @@
      * @param int $timeout
      */
-    public function __construct($server, $path = false, $port = false, $timeout = 15) {
+    public function __construct( $server, $path = false, $port = false, $timeout = 15 ) {
         if ( ! $path ) {
             // Assume we have been given a URL instead
-            $bits = parse_url($server);
+            $bits         = parse_url( $server );
             $this->scheme = $bits['scheme'];
             $this->server = $bits['host'];
-            $this->port = isset($bits['port']) ? $bits['port'] : $port;
-            $this->path = !empty($bits['path']) ? $bits['path'] : '/';
+            $this->port   = isset( $bits['port'] ) ? $bits['port'] : $port;
+            $this->path   = ! empty( $bits['path'] ) ? $bits['path'] : '/';
 
             // Make absolutely sure we have a path
@@ -40 +39 @@
             $this->scheme = 'http';
             $this->server = $server;
-            $this->path = $path;
-            $this->port = $port;
+            $this->path   = $path;
+            $this->port   = $port;
         }
         $this->useragent = 'The Incutio XML-RPC PHP Library';
-        $this->timeout = $timeout;
+        $this->timeout   = $timeout;
     }
 
@@ -51 +50 @@
      */
     public function query() {
-        $args = func_get_args();
-        $method = array_shift($args);
-        $request = new IXR_Request($method, $args);
-        $xml = $request->getXml();
+        $args    = func_get_args();
+        $method  = array_shift( $args );
+        $request = new IXR_Request( $method, $args );
+        $xml     = $request->getXml();
 
         $port = $this->port ? ":$this->port" : '';
-        $url = $this->scheme . '://' . $this->server . $port . $this->path;
+        $url  = $this->scheme . '://' . $this->server . $port . $this->path;
         $args = array(
-            'headers'    => array('Content-Type' => 'text/xml'),
+            'headers'    => array( 'Content-Type' => 'text/xml' ),
             'user-agent' => $this->useragent,
             'body'       => $xml,
@@ -66 +65 @@
         // Merge Custom headers ala #8145
         foreach ( $this->headers as $header => $value ) {
-            $args['headers'][$header] = $value;
+            $args['headers'][ $header ] = $value;
         }
 
@@ -84 +83 @@
         // Now send the request
         if ( $this->debug ) {
-            echo '<pre class="ixr_request">' . htmlspecialchars($xml) . "\n</pre>\n\n";
+            echo '<pre class="ixr_request">' . htmlspecialchars( $xml ) . "\n</pre>\n\n";
         }
 
-        $response = wp_remote_post($url, $args);
+        $response = wp_remote_post( $url, $args );
 
-        if ( is_wp_error($response) ) {
-            $errno    = $response->get_error_code();
-            $errorstr = $response->get_error_message();
-            $this->error = new IXR_Error(-32300, "transport error: $errno $errorstr");
+        if ( is_wp_error( $response ) ) {
+            $errno       = $response->get_error_code();
+            $errorstr    = $response->get_error_message();
+            $this->error = new IXR_Error( -32300, "transport error: $errno $errorstr" );
             return false;
         }
 
         if ( 200 != wp_remote_retrieve_response_code( $response ) ) {
-            $this->error = new IXR_Error(-32301, 'transport error - HTTP status code was not 200 (' . wp_remote_retrieve_response_code( $response ) . ')');
+            $this->error = new IXR_Error( -32301, 'transport error - HTTP status code was not 200 (' . wp_remote_retrieve_response_code( $response ) . ')' );
             return false;
         }
@@ -109 +108 @@
         if ( ! $this->message->parse() ) {
             // XML error
-            $this->error = new IXR_Error(-32700, 'parse error. not well formed');
+            $this->error = new IXR_Error( -32700, 'parse error. not well formed' );
             return false;
         }
@@ -115 +114 @@
         // Is the message a fault?
         if ( $this->message->messageType == 'fault' ) {
-            $this->error = new IXR_Error($this->message->faultCode, $this->message->faultString);
+            $this->error = new IXR_Error( $this->message->faultCode, $this->message->faultString );
             return false;
         }