Changeset 42343 for trunk/src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php

Timestamp:

11/30/2017 11:09:33 PM (7 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php (modified) (12 diffs)

trunk/src/wp-includes/customize/class-wp-customize-nav-menu-item-setting.php

@@ -234 +234 @@
                 if ( $post && self::POST_TYPE === $post->post_type ) {
                     $is_title_empty = empty( $post->post_title );
-                    $value = (array) wp_setup_nav_menu_item( $post );
+                    $value          = (array) wp_setup_nav_menu_item( $post );
                     if ( $is_title_empty ) {
                         $value['title'] = '';
@@ -353 +353 @@
 
         if ( ! isset( $this->value['nav_menu_term_id'] ) && $this->post_id > 0 ) {
-            $menus = wp_get_post_terms( $this->post_id, WP_Customize_Nav_Menu_Setting::TAXONOMY, array(
-                'fields' => 'ids',
-            ) );
+            $menus = wp_get_post_terms(
+                $this->post_id, WP_Customize_Nav_Menu_Setting::TAXONOMY, array(
+                    'fields' => 'ids',
+                )
+            );
             if ( ! empty( $menus ) ) {
                 $this->value['nav_menu_term_id'] = array_shift( $menus );
@@ -380 +382 @@
         if ( ! isset( $this->value['_invalid'] ) ) {
             $this->value['_invalid'] = false;
-            $is_known_invalid = (
+            $is_known_invalid        = (
                 ( ( 'post_type' === $this->value['type'] || 'post_type_archive' === $this->value['type'] ) && ! post_type_exists( $this->value['object'] ) )
                 ||
@@ -436 +438 @@
         }
 
-        $undefined = new stdClass();
+        $undefined      = new stdClass();
         $is_placeholder = ( $this->post_id < 0 );
-        $is_dirty = ( $undefined !== $this->post_value( $undefined ) );
+        $is_dirty       = ( $undefined !== $this->post_value( $undefined ) );
         if ( ! $is_placeholder && ! $is_dirty ) {
             return false;
@@ -473 +475 @@
      */
     public function filter_wp_get_nav_menu_items( $items, $menu, $args ) {
-        $this_item = $this->value();
+        $this_item                = $this->value();
         $current_nav_menu_term_id = $this_item['nav_menu_term_id'];
         unset( $this_item['nav_menu_term_id'] );
@@ -508 +510 @@
         }
 
-        $mutated = false;
+        $mutated       = false;
         $should_update = (
             is_array( $this_item )
@@ -556 +558 @@
 
         if ( ARRAY_A === $args['output'] ) {
-            $items = wp_list_sort( $items, array(
-                $args['output_key'] => 'ASC',
-            ) );
-            $i = 1;
+            $items = wp_list_sort(
+                $items, array(
+                    $args['output_key'] => 'ASC',
+                )
+            );
+            $i     = 1;
 
             foreach ( $items as $k => $item ) {
@@ -583 +587 @@
         unset( $item->status );
 
-        $item->post_type = 'nav_menu_item';
+        $item->post_type  = 'nav_menu_item';
         $item->menu_order = $item->position;
         unset( $item->position );
@@ -597 +601 @@
         }
 
-        $item->ID = $this->post_id;
+        $item->ID    = $this->post_id;
         $item->db_id = $this->post_id;
-        $post = new WP_Post( (object) $item );
+        $post        = new WP_Post( (object) $item );
 
         if ( empty( $post->post_author ) ) {
@@ -656 +660 @@
         }
 
-        $default = array(
+        $default                     = array(
             'object_id'        => 0,
             'object'           => '',
@@ -674 +678 @@
             '_invalid'         => false,
         );
-        $menu_item_value = array_merge( $default, $menu_item_value );
-        $menu_item_value = wp_array_slice_assoc( $menu_item_value, array_keys( $default ) );
+        $menu_item_value             = array_merge( $default, $menu_item_value );
+        $menu_item_value             = wp_array_slice_assoc( $menu_item_value, array_keys( $default ) );
         $menu_item_value['position'] = intval( $menu_item_value['position'] );
 
@@ -850 +854 @@
             if ( is_wp_error( $r ) ) {
                 $this->update_status = 'error';
-                $this->update_error = $r;
+                $this->update_error  = $r;
             } else {
                 if ( $is_placeholder ) {
                     $this->previous_post_id = $this->post_id;
-                    $this->post_id = $r;
-                    $this->update_status = 'inserted';
+                    $this->post_id          = $r;
+                    $this->update_status    = 'inserted';
                 } else {
                     $this->update_status = 'updated';