Changeset 42343 for trunk/src/wp-includes/functions.wp-scripts.php

Timestamp:

11/30/2017 11:09:33 PM (7 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-includes/functions.wp-scripts.php (modified) (6 diffs)

trunk/src/wp-includes/functions.wp-scripts.php

@@ -39 +39 @@
     }
 
-    _doing_it_wrong( $function, sprintf(
-        /* translators: 1: wp_enqueue_scripts, 2: admin_enqueue_scripts, 3: login_enqueue_scripts */
-        __( 'Scripts and styles should not be registered or enqueued until the %1$s, %2$s, or %3$s hooks.' ),
-        '<code>wp_enqueue_scripts</code>',
-        '<code>admin_enqueue_scripts</code>',
-        '<code>login_enqueue_scripts</code>'
-    ), '3.3.0' );
+    _doing_it_wrong(
+        $function, sprintf(
+            /* translators: 1: wp_enqueue_scripts, 2: admin_enqueue_scripts, 3: login_enqueue_scripts */
+            __( 'Scripts and styles should not be registered or enqueued until the %1$s, %2$s, or %3$s hooks.' ),
+            '<code>wp_enqueue_scripts</code>',
+            '<code>admin_enqueue_scripts</code>',
+            '<code>login_enqueue_scripts</code>'
+        ), '3.3.0'
+    );
 }
 
@@ -109 +111 @@
 
     if ( false !== stripos( $data, '</script>' ) ) {
-        _doing_it_wrong( __FUNCTION__, sprintf(
-            /* translators: 1: <script>, 2: wp_add_inline_script() */
-            __( 'Do not pass %1$s tags to %2$s.' ),
-            '<code>&lt;script&gt;</code>',
-            '<code>wp_add_inline_script()</code>'
-        ), '4.5.0' );
+        _doing_it_wrong(
+            __FUNCTION__, sprintf(
+                /* translators: 1: <script>, 2: wp_add_inline_script() */
+                __( 'Do not pass %1$s tags to %2$s.' ),
+                '<code>&lt;script&gt;</code>',
+                '<code>wp_add_inline_script()</code>'
+            ), '4.5.0'
+        );
         $data = trim( preg_replace( '#<script[^>]*>(.*)</script>#is', '$1', $data ) );
     }
@@ -168 +172 @@
  *     }
  *
- *
  * @see WP_Dependencies::localize()
  * @link https://core.trac.wordpress.org/ticket/11520
@@ -217 +220 @@
     ) {
         $no = array(
-            'jquery', 'jquery-core', 'jquery-migrate', 'jquery-ui-core', 'jquery-ui-accordion',
-            'jquery-ui-autocomplete', 'jquery-ui-button', 'jquery-ui-datepicker', 'jquery-ui-dialog',
-            'jquery-ui-draggable', 'jquery-ui-droppable', 'jquery-ui-menu', 'jquery-ui-mouse',
-            'jquery-ui-position', 'jquery-ui-progressbar', 'jquery-ui-resizable', 'jquery-ui-selectable',
-            'jquery-ui-slider', 'jquery-ui-sortable', 'jquery-ui-spinner', 'jquery-ui-tabs',
-            'jquery-ui-tooltip', 'jquery-ui-widget', 'underscore', 'backbone',
+            'jquery',
+            'jquery-core',
+            'jquery-migrate',
+            'jquery-ui-core',
+            'jquery-ui-accordion',
+            'jquery-ui-autocomplete',
+            'jquery-ui-button',
+            'jquery-ui-datepicker',
+            'jquery-ui-dialog',
+            'jquery-ui-draggable',
+            'jquery-ui-droppable',
+            'jquery-ui-menu',
+            'jquery-ui-mouse',
+            'jquery-ui-position',
+            'jquery-ui-progressbar',
+            'jquery-ui-resizable',
+            'jquery-ui-selectable',
+            'jquery-ui-slider',
+            'jquery-ui-sortable',
+            'jquery-ui-spinner',
+            'jquery-ui-tabs',
+            'jquery-ui-tooltip',
+            'jquery-ui-widget',
+            'underscore',
+            'backbone',
         );
 
@@ -267 +289 @@
     _wp_scripts_maybe_doing_it_wrong( __FUNCTION__ );
 
-
     if ( $src || $in_footer ) {
         $_handle = explode( '?', $handle );
@@ -332 +353 @@
  * @return bool True on success, false on failure.
  */
-function wp_script_add_data( $handle, $key, $value ){
+function wp_script_add_data( $handle, $key, $value ) {
     return wp_scripts()->add_data( $handle, $key, $value );
 }