Changeset 42343 for trunk/src/wp-includes/widgets/class-wp-widget-custom-html.php

Timestamp:

11/30/2017 11:09:33 PM (7 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-includes/widgets/class-wp-widget-custom-html.php (modified) (10 diffs)

trunk/src/wp-includes/widgets/class-wp-widget-custom-html.php

@@ -32 +32 @@
      */
     protected $default_instance = array(
-        'title' => '',
+        'title'   => '',
         'content' => '',
     );
@@ -42 +42 @@
      */
     public function __construct() {
-        $widget_ops = array(
-            'classname' => 'widget_custom_html',
-            'description' => __( 'Arbitrary HTML code.' ),
+        $widget_ops  = array(
+            'classname'                   => 'widget_custom_html',
+            'description'                 => __( 'Arbitrary HTML code.' ),
             'customize_selective_refresh' => true,
         );
         $control_ops = array(
-            'width' => 400,
+            'width'  => 400,
             'height' => 350,
         );
@@ -131 +131 @@
 
         // Prepare instance data that looks like a normal Text widget.
-        $simulated_text_widget_instance = array_merge( $instance, array(
-            'text' => isset( $instance['content'] ) ? $instance['content'] : '',
-            'filter' => false, // Because wpautop is not applied.
-            'visual' => false, // Because it wasn't created in TinyMCE.
-        ) );
+        $simulated_text_widget_instance = array_merge(
+            $instance, array(
+                'text'   => isset( $instance['content'] ) ? $instance['content'] : '',
+                'filter' => false, // Because wpautop is not applied.
+                'visual' => false, // Because it wasn't created in TinyMCE.
+            )
+        );
         unset( $simulated_text_widget_instance['content'] ); // Was moved to 'text' prop.
 
@@ -180 +182 @@
      */
     public function update( $new_instance, $old_instance ) {
-        $instance = array_merge( $this->default_instance, $old_instance );
+        $instance          = array_merge( $this->default_instance, $old_instance );
         $instance['title'] = sanitize_text_field( $new_instance['title'] );
         if ( current_user_can( 'unfiltered_html' ) ) {
@@ -196 +198 @@
      */
     public function enqueue_admin_scripts() {
-        $settings = wp_enqueue_code_editor( array(
-            'type' => 'text/html',
-            'codemirror' => array(
-                'indentUnit' => 2,
-                'tabSize' => 2,
-            ),
-        ) );
+        $settings = wp_enqueue_code_editor(
+            array(
+                'type'       => 'text/html',
+                'codemirror' => array(
+                    'indentUnit' => 2,
+                    'tabSize'    => 2,
+                ),
+            )
+        );
 
         wp_enqueue_script( 'custom-html-widgets' );
@@ -217 +221 @@
                 'singular' => _n( 'There is %d error which must be fixed before you can save.', 'There are %d errors which must be fixed before you can save.', 1 ),
                 /* translators: %d: error count */
-                'plural' => _n( 'There is %d error which must be fixed before you can save.', 'There are %d errors which must be fixed before you can save.', 2 ), // @todo This is lacking, as some languages have a dedicated dual form. For proper handling of plurals in JS, see #20491.
+                'plural'   => _n( 'There is %d error which must be fixed before you can save.', 'There are %d errors which must be fixed before you can save.', 2 ), // @todo This is lacking, as some languages have a dedicated dual form. For proper handling of plurals in JS, see #20491.
             ),
         );
@@ -263 +267 @@
                 <?php
                 $probably_unsafe_html = array( 'script', 'iframe', 'form', 'input', 'style' );
-                $allowed_html = wp_kses_allowed_html( 'post' );
-                $disallowed_html = array_diff( $probably_unsafe_html, array_keys( $allowed_html ) );
+                $allowed_html         = wp_kses_allowed_html( 'post' );
+                $disallowed_html      = array_diff( $probably_unsafe_html, array_keys( $allowed_html ) );
                 ?>
                 <?php if ( ! empty( $disallowed_html ) ) : ?>
@@ -289 +293 @@
         $screen = get_current_screen();
 
-        $content = '<p>';
+        $content  = '<p>';
         $content .= __( 'Use the Custom HTML widget to add arbitrary HTML code to your widget areas.' );
         $content .= '</p>';
@@ -300 +304 @@
                 esc_url( get_edit_profile_url() ),
                 'class="external-link" target="_blank"',
-                sprintf( '<span class="screen-reader-text"> %s</span>',
+                sprintf(
+                    '<span class="screen-reader-text"> %s</span>',
                     /* translators: accessibility text */
                     __( '(opens in a new window)' )
@@ -315 +320 @@
         }
 
-        $screen->add_help_tab( array(
-            'id' => 'custom_html_widget',
-            'title' => __( 'Custom HTML Widget' ),
-            'content' => $content,
-        ) );
+        $screen->add_help_tab(
+            array(
+                'id'      => 'custom_html_widget',
+                'title'   => __( 'Custom HTML Widget' ),
+                'content' => $content,
+            )
+        );
     }
 }