Changeset 42343 for trunk/src/wp-includes/widgets/class-wp-widget-media-video.php

Timestamp:

11/30/2017 11:09:33 PM (7 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/wp-includes/widgets/class-wp-widget-media-video.php (modified) (5 diffs)

trunk/src/wp-includes/widgets/class-wp-widget-media-video.php

@@ -23 +23 @@
      */
     public function __construct() {
-        parent::__construct( 'media_video', __( 'Video' ), array(
-            'description' => __( 'Displays a video from the media library or from YouTube, Vimeo, or another provider.' ),
-            'mime_type'   => 'video',
-        ) );
-
-        $this->l10n = array_merge( $this->l10n, array(
-            'no_media_selected' => __( 'No video selected' ),
-            'add_media' => _x( 'Add Video', 'label for button in the video widget' ),
-            'replace_media' => _x( 'Replace Video', 'label for button in the video widget; should preferably not be longer than ~13 characters long' ),
-            'edit_media' => _x( 'Edit Video', 'label for button in the video widget; should preferably not be longer than ~13 characters long' ),
-            'missing_attachment' => sprintf(
-                /* translators: %s: URL to media library */
-                __( 'We can&#8217;t find that video. Check your <a href="%s">media library</a> and make sure it wasn&#8217;t deleted.' ),
-                esc_url( admin_url( 'upload.php' ) )
-            ),
-            /* translators: %d: widget count */
-            'media_library_state_multi' => _n_noop( 'Video Widget (%d)', 'Video Widget (%d)' ),
-            'media_library_state_single' => __( 'Video Widget' ),
-            /* translators: %s: a list of valid video file extensions */
-            'unsupported_file_type' => sprintf( __( 'Sorry, we can&#8217;t load the video at the supplied URL. Please check that the URL is for a supported video file (%s) or stream (e.g. YouTube and Vimeo).' ), '<code>.' . implode( '</code>, <code>.', wp_get_video_extensions() ) . '</code>' ),
-        ) );
+        parent::__construct(
+            'media_video', __( 'Video' ), array(
+                'description' => __( 'Displays a video from the media library or from YouTube, Vimeo, or another provider.' ),
+                'mime_type'   => 'video',
+            )
+        );
+
+        $this->l10n = array_merge(
+            $this->l10n, array(
+                'no_media_selected'          => __( 'No video selected' ),
+                'add_media'                  => _x( 'Add Video', 'label for button in the video widget' ),
+                'replace_media'              => _x( 'Replace Video', 'label for button in the video widget; should preferably not be longer than ~13 characters long' ),
+                'edit_media'                 => _x( 'Edit Video', 'label for button in the video widget; should preferably not be longer than ~13 characters long' ),
+                'missing_attachment'         => sprintf(
+                    /* translators: %s: URL to media library */
+                    __( 'We can&#8217;t find that video. Check your <a href="%s">media library</a> and make sure it wasn&#8217;t deleted.' ),
+                    esc_url( admin_url( 'upload.php' ) )
+                ),
+                /* translators: %d: widget count */
+                'media_library_state_multi'  => _n_noop( 'Video Widget (%d)', 'Video Widget (%d)' ),
+                'media_library_state_single' => __( 'Video Widget' ),
+                /* translators: %s: a list of valid video file extensions */
+                'unsupported_file_type'      => sprintf( __( 'Sorry, we can&#8217;t load the video at the supplied URL. Please check that the URL is for a supported video file (%s) or stream (e.g. YouTube and Vimeo).' ), '<code>.' . implode( '</code>, <code>.', wp_get_video_extensions() ) . '</code>' ),
+            )
+        );
     }
 
@@ -61 +65 @@
             array(
                 'preload' => array(
-                    'type' => 'string',
-                    'enum' => array( 'none', 'auto', 'metadata' ),
-                    'default' => 'metadata',
-                    'description' => __( 'Preload' ),
+                    'type'                  => 'string',
+                    'enum'                  => array( 'none', 'auto', 'metadata' ),
+                    'default'               => 'metadata',
+                    'description'           => __( 'Preload' ),
                     'should_preview_update' => false,
                 ),
-                'loop' => array(
-                    'type' => 'boolean',
-                    'default' => false,
-                    'description' => __( 'Loop' ),
+                'loop'    => array(
+                    'type'                  => 'boolean',
+                    'default'               => false,
+                    'description'           => __( 'Loop' ),
                     'should_preview_update' => false,
                 ),
                 'content' => array(
-                    'type' => 'string',
-                    'default' => '',
-                    'sanitize_callback' => 'wp_kses_post',
-                    'description' => __( 'Tracks (subtitles, captions, descriptions, chapters, or metadata)' ),
+                    'type'                  => 'string',
+                    'default'               => '',
+                    'sanitize_callback'     => 'wp_kses_post',
+                    'description'           => __( 'Tracks (subtitles, captions, descriptions, chapters, or metadata)' ),
                     'should_preview_update' => false,
                 ),
@@ -85 +89 @@
         foreach ( wp_get_video_extensions() as $video_extension ) {
             $schema[ $video_extension ] = array(
-                'type' => 'string',
-                'default' => '',
-                'format' => 'uri',
+                'type'        => 'string',
+                'default'     => '',
+                'format'      => 'uri',
                 /* translators: %s: video extension */
                 'description' => sprintf( __( 'URL to the %s video source file' ), $video_extension ),
@@ -106 +110 @@
      */
     public function render_media( $instance ) {
-        $instance = array_merge( wp_list_pluck( $this->get_instance_schema(), 'default' ), $instance );
+        $instance   = array_merge( wp_list_pluck( $this->get_instance_schema(), 'default' ), $instance );
         $attachment = null;
 
@@ -244 +248 @@
                 </a>
             <# } else if ( data.model.src ) { #>
-                <?php wp_underscore_video_template() ?>
+                <?php wp_underscore_video_template(); ?>
             <# } #>
         </script>