Changeset 42343 for trunk/src/xmlrpc.php

Timestamp:

11/30/2017 11:09:33 PM (8 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/src/xmlrpc.php (modified) (6 diffs)

trunk/src/xmlrpc.php

@@ -11 +11 @@
  * @var bool
  */
-define('XMLRPC_REQUEST', true);
+define( 'XMLRPC_REQUEST', true );
 
 // Some browser-embedded clients send cookies. We don't want them.
@@ -18 +18 @@
 // A bug in PHP < 5.2.2 makes $HTTP_RAW_POST_DATA not set by default,
 // but we can do it ourself.
-if ( !isset( $HTTP_RAW_POST_DATA ) ) {
+if ( ! isset( $HTTP_RAW_POST_DATA ) ) {
     $HTTP_RAW_POST_DATA = file_get_contents( 'php://input' );
 }
 
 // fix for mozBlog and other cases where '<?xml' isn't on the very first line
-if ( isset($HTTP_RAW_POST_DATA) )
-    $HTTP_RAW_POST_DATA = trim($HTTP_RAW_POST_DATA);
+if ( isset( $HTTP_RAW_POST_DATA ) ) {
+    $HTTP_RAW_POST_DATA = trim( $HTTP_RAW_POST_DATA );
+}
 
 /** Include the bootstrap for setting up WordPress environment */
@@ -30 +31 @@
 
 if ( isset( $_GET['rsd'] ) ) { // http://cyber.law.harvard.edu/blogs/gems/tech/rsd.html
-header('Content-Type: text/xml; charset=' . get_option('blog_charset'), true);
+    header( 'Content-Type: text/xml; charset=' . get_option( 'blog_charset' ), true );
 ?>
-<?php echo '<?xml version="1.0" encoding="'.get_option('blog_charset').'"?'.'>'; ?>
+<?php echo '<?xml version="1.0" encoding="' . get_option( 'blog_charset' ) . '"?' . '>'; ?>
 <rsd version="1.0" xmlns="http://archipelago.phrasewise.com/rsd">
     <service>
         <engineName>WordPress</engineName>
         <engineLink>https://wordpress.org/</engineLink>
-        <homePageLink><?php bloginfo_rss('url') ?></homePageLink>
+        <homePageLink><?php bloginfo_rss( 'url' ); ?></homePageLink>
         <apis>
-            <api name="WordPress" blogID="1" preferred="true" apiLink="<?php echo site_url('xmlrpc.php', 'rpc') ?>" />
-            <api name="Movable Type" blogID="1" preferred="false" apiLink="<?php echo site_url('xmlrpc.php', 'rpc') ?>" />
-            <api name="MetaWeblog" blogID="1" preferred="false" apiLink="<?php echo site_url('xmlrpc.php', 'rpc') ?>" />
-            <api name="Blogger" blogID="1" preferred="false" apiLink="<?php echo site_url('xmlrpc.php', 'rpc') ?>" />
+            <api name="WordPress" blogID="1" preferred="true" apiLink="<?php echo site_url( 'xmlrpc.php', 'rpc' ); ?>" />
+            <api name="Movable Type" blogID="1" preferred="false" apiLink="<?php echo site_url( 'xmlrpc.php', 'rpc' ); ?>" />
+            <api name="MetaWeblog" blogID="1" preferred="false" apiLink="<?php echo site_url( 'xmlrpc.php', 'rpc' ); ?>" />
+            <api name="Blogger" blogID="1" preferred="false" apiLink="<?php echo site_url( 'xmlrpc.php', 'rpc' ); ?>" />
             <?php
             /**
@@ -60 +61 @@
 }
 
-include_once(ABSPATH . 'wp-admin/includes/admin.php');
-include_once(ABSPATH . WPINC . '/class-IXR.php');
-include_once(ABSPATH . WPINC . '/class-wp-xmlrpc-server.php'); 
+include_once( ABSPATH . 'wp-admin/includes/admin.php' );
+include_once( ABSPATH . WPINC . '/class-IXR.php' );
+include_once( ABSPATH . WPINC . '/class-wp-xmlrpc-server.php' );
 
 /**
  * Posts submitted via the XML-RPC interface get that title
+ *
  * @name post_default_title
  * @var string
  */
-$post_default_title = "";
+$post_default_title = '';
 
 /**
@@ -79 +81 @@
  */
 $wp_xmlrpc_server_class = apply_filters( 'wp_xmlrpc_server_class', 'wp_xmlrpc_server' );
-$wp_xmlrpc_server = new $wp_xmlrpc_server_class;
+$wp_xmlrpc_server       = new $wp_xmlrpc_server_class;
 
 // Fire off the request
@@ -97 +99 @@
 function logIO( $io, $msg ) {
     _deprecated_function( __FUNCTION__, '3.4.0', 'error_log()' );
-    if ( ! empty( $GLOBALS['xmlrpc_logging'] ) )
+    if ( ! empty( $GLOBALS['xmlrpc_logging'] ) ) {
         error_log( $io . ' - ' . $msg );
+    }
 }