Changeset 42343 for trunk/tests/phpunit/includes/factory/class-wp-unittest-factory-for-attachment.php

Timestamp:

11/30/2017 11:09:33 PM (8 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/tests/phpunit/includes/factory/class-wp-unittest-factory-for-attachment.php (modified) (2 diffs)

trunk/tests/phpunit/includes/factory/class-wp-unittest-factory-for-attachment.php

@@ -18 +18 @@
         // Backward compatibility for legacy argument format.
         if ( is_string( $args ) ) {
-            $file = $args;
-            $args = $legacy_args;
+            $file                = $args;
+            $args                = $legacy_args;
             $args['post_parent'] = $legacy_parent;
-            $args['file'] = $file;
+            $args['file']        = $file;
         }
 
-        $r = array_merge( array(
-            'file' => '',
-            'post_parent' => 0,
-        ), $args );
+        $r = array_merge(
+            array(
+                'file'        => '',
+                'post_parent' => 0,
+            ), $args
+        );
 
         return wp_insert_attachment( $r, $r['file'], $r['post_parent'] );
@@ -33 +35 @@
 
     function create_upload_object( $file, $parent = 0 ) {
-        $contents = file_get_contents($file);
-        $upload = wp_upload_bits(basename($file), null, $contents);
+        $contents = file_get_contents( $file );
+        $upload   = wp_upload_bits( basename( $file ), null, $contents );
 
         $type = '';
-        if ( ! empty($upload['type']) ) {
+        if ( ! empty( $upload['type'] ) ) {
             $type = $upload['type'];
         } else {
             $mime = wp_check_filetype( $upload['file'] );
-            if ($mime)
+            if ( $mime ) {
                 $type = $mime['type'];
+            }
         }
 
         $attachment = array(
-            'post_title' => basename( $upload['file'] ),
-            'post_content' => '',
-            'post_type' => 'attachment',
-            'post_parent' => $parent,
+            'post_title'     => basename( $upload['file'] ),
+            'post_content'   => '',
+            'post_type'      => 'attachment',
+            'post_parent'    => $parent,
             'post_mime_type' => $type,
-            'guid' => $upload[ 'url' ],
+            'guid'           => $upload['url'],
         );
 
         // Save the data
-        $id = wp_insert_attachment( $attachment, $upload[ 'file' ], $parent );
+        $id = wp_insert_attachment( $attachment, $upload['file'], $parent );
         wp_update_attachment_metadata( $id, wp_generate_attachment_metadata( $id, $upload['file'] ) );