Changeset 42343 for trunk/tests/phpunit/includes/testcase-ajax.php

Timestamp:

11/30/2017 11:09:33 PM (8 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/tests/phpunit/includes/testcase-ajax.php (modified) (9 diffs)

trunk/tests/phpunit/includes/testcase-ajax.php

@@ -19 +19 @@
     /**
      * Last AJAX response.  This is set via echo -or- wp_die.
+     *
      * @var string
      */
@@ -25 +26 @@
     /**
      * List of ajax actions called via GET
+     *
      * @var array
      */
     protected static $_core_actions_get = array(
-        'fetch-list', 'ajax-tag-search', 'wp-compression-test', 'imgedit-preview', 'oembed-cache',
-        'autocomplete-user', 'dashboard-widgets', 'logged-in',
+        'fetch-list',
+        'ajax-tag-search',
+        'wp-compression-test',
+        'imgedit-preview',
+        'oembed-cache',
+        'autocomplete-user',
+        'dashboard-widgets',
+        'logged-in',
     );
 
     /**
      * Saved error reporting level
+     *
      * @var int
      */
@@ -40 +49 @@
     /**
      * List of ajax actions called via POST
+     *
      * @var array
      */
     protected static $_core_actions_post = array(
-        'oembed_cache', 'image-editor', 'delete-comment', 'delete-tag', 'delete-link',
-        'delete-meta', 'delete-post', 'trash-post', 'untrash-post', 'delete-page', 'dim-comment',
-        'add-link-category', 'add-tag', 'get-tagcloud', 'get-comments', 'replyto-comment',
-        'edit-comment', 'add-menu-item', 'add-meta', 'add-user', 'closed-postboxes',
-        'hidden-columns', 'update-welcome-panel', 'menu-get-metabox', 'wp-link-ajax',
-        'menu-locations-save', 'menu-quick-search', 'meta-box-order', 'get-permalink',
-        'sample-permalink', 'inline-save', 'inline-save-tax', 'find_posts', 'widgets-order',
-        'save-widget', 'set-post-thumbnail', 'date_format', 'time_format', 'wp-fullscreen-save-post',
-        'wp-remove-post-lock', 'dismiss-wp-pointer', 'send-attachment-to-editor', 'heartbeat', 'nopriv_heartbeat', 'get-revision-diffs',
-        'save-user-color-scheme', 'update-widget', 'query-themes', 'parse-embed', 'set-attachment-thumbnail',
-        'parse-media-shortcode', 'destroy-sessions', 'install-plugin', 'update-plugin', 'press-this-save-post',
-        'press-this-add-category', 'crop-image', 'generate-password', 'save-wporg-username', 'delete-plugin',
-        'search-plugins', 'search-install-plugins', 'activate-plugin', 'update-theme', 'delete-theme',
-        'install-theme', 'get-post-thumbnail-html',
+        'oembed_cache',
+        'image-editor',
+        'delete-comment',
+        'delete-tag',
+        'delete-link',
+        'delete-meta',
+        'delete-post',
+        'trash-post',
+        'untrash-post',
+        'delete-page',
+        'dim-comment',
+        'add-link-category',
+        'add-tag',
+        'get-tagcloud',
+        'get-comments',
+        'replyto-comment',
+        'edit-comment',
+        'add-menu-item',
+        'add-meta',
+        'add-user',
+        'closed-postboxes',
+        'hidden-columns',
+        'update-welcome-panel',
+        'menu-get-metabox',
+        'wp-link-ajax',
+        'menu-locations-save',
+        'menu-quick-search',
+        'meta-box-order',
+        'get-permalink',
+        'sample-permalink',
+        'inline-save',
+        'inline-save-tax',
+        'find_posts',
+        'widgets-order',
+        'save-widget',
+        'set-post-thumbnail',
+        'date_format',
+        'time_format',
+        'wp-fullscreen-save-post',
+        'wp-remove-post-lock',
+        'dismiss-wp-pointer',
+        'send-attachment-to-editor',
+        'heartbeat',
+        'nopriv_heartbeat',
+        'get-revision-diffs',
+        'save-user-color-scheme',
+        'update-widget',
+        'query-themes',
+        'parse-embed',
+        'set-attachment-thumbnail',
+        'parse-media-shortcode',
+        'destroy-sessions',
+        'install-plugin',
+        'update-plugin',
+        'press-this-save-post',
+        'press-this-add-category',
+        'crop-image',
+        'generate-password',
+        'save-wporg-username',
+        'delete-plugin',
+        'search-plugins',
+        'search-install-plugins',
+        'activate-plugin',
+        'update-theme',
+        'delete-theme',
+        'install-theme',
+        'get-post-thumbnail-html',
     );
 
@@ -104 +167 @@
         parent::tearDown();
         $_POST = array();
-        $_GET = array();
+        $_GET  = array();
         unset( $GLOBALS['post'] );
         unset( $GLOBALS['comment'] );
@@ -118 +181 @@
     public function logout() {
         unset( $GLOBALS['current_user'] );
-        $cookies = array(AUTH_COOKIE, SECURE_AUTH_COOKIE, LOGGED_IN_COOKIE, USER_COOKIE, PASS_COOKIE);
-        foreach ( $cookies as $c )
-            unset( $_COOKIE[$c] );
+        $cookies = array( AUTH_COOKIE, SECURE_AUTH_COOKIE, LOGGED_IN_COOKIE, USER_COOKIE, PASS_COOKIE );
+        foreach ( $cookies as $c ) {
+            unset( $_COOKIE[ $c ] );
+        }
     }
 
     /**
      * Return our callback handler
+     *
      * @return callback
      */
@@ -144 +209 @@
      * $this->setExpectedException( 'WPAjaxDieContinueException', 'something contained in $message' );
      * </code>
+     *
      * @param string $message
      */
@@ -163 +229 @@
      * Switch between user roles
      * E.g. administrator, editor, author, contributor, subscriber
+     *
      * @param string $role
      */
     protected function _setRole( $role ) {
-        $post = $_POST;
+        $post    = $_POST;
         $user_id = self::factory()->user->create( array( 'role' => $role ) );
         wp_set_current_user( $user_id );
-        $_POST = array_merge($_POST, $post);
+        $_POST = array_merge( $_POST, $post );
     }
 
@@ -176 +243 @@
      * Capture the output via output buffering, and if there is any, store
      * it in $this->_last_response.
+     *
      * @param string $action
      */
@@ -195 +263 @@
         // Save the output
         $buffer = ob_get_clean();
-        if ( !empty( $buffer ) )
+        if ( ! empty( $buffer ) ) {
             $this->_last_response = $buffer;
+        }
     }
 }