Changeset 42343 for trunk/tests/phpunit/tests/admin/includesPlugin.php

Timestamp:

11/30/2017 11:09:33 PM (7 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/tests/phpunit/tests/admin/includesPlugin.php (modified) (9 diffs)

trunk/tests/phpunit/tests/admin/includesPlugin.php

@@ -9 +9 @@
 
         $default_headers = array(
-            'Name' => 'Hello Dolly',
-            'Title' => '<a href="http://wordpress.org/#">Hello Dolly</a>',
-            'PluginURI' => 'http://wordpress.org/#',
+            'Name'        => 'Hello Dolly',
+            'Title'       => '<a href="http://wordpress.org/#">Hello Dolly</a>',
+            'PluginURI'   => 'http://wordpress.org/#',
             'Description' => 'This is not just a plugin, it symbolizes the hope and enthusiasm of an entire generation summed up in two words sung most famously by Louis Armstrong: Hello, Dolly. When activated you will randomly see a lyric from Hello, Dolly in the upper right of your admin screen on every page. <cite>By <a href="http://ma.tt/">Matt Mullenweg</a>.</cite>',
-            'Author' => '<a href="http://ma.tt/">Matt Mullenweg</a>',
-            'AuthorURI' => 'http://ma.tt/',
-            'Version' => '1.5.1',
-            'TextDomain' => 'hello-dolly',
-            'DomainPath' => ''
+            'Author'      => '<a href="http://ma.tt/">Matt Mullenweg</a>',
+            'AuthorURI'   => 'http://ma.tt/',
+            'Version'     => '1.5.1',
+            'TextDomain'  => 'hello-dolly',
+            'DomainPath'  => '',
         );
 
-        $this->assertTrue( is_array($data) );
-
-        foreach ($default_headers as $name => $value) {
-            $this->assertTrue(isset($data[$name]));
-            $this->assertEquals($value, $data[$name]);
+        $this->assertTrue( is_array( $data ) );
+
+        foreach ( $default_headers as $name => $value ) {
+            $this->assertTrue( isset( $data[ $name ] ) );
+            $this->assertEquals( $value, $data[ $name ] );
         }
     }
@@ -42 +42 @@
         add_pages_page( 'Appending Query Arg', 'Test Pages', 'edit_pages', 'testpages', 'mt_pages_page' );
 
-        $expected['testsettings'] = 'http://example.com/wp-admin/options-general.php?page=testsettings';
-        $expected['testtools'] = 'http://example.com/wp-admin/tools.php?page=testtools';
+        $expected['testsettings']        = 'http://example.com/wp-admin/options-general.php?page=testsettings';
+        $expected['testtools']           = 'http://example.com/wp-admin/tools.php?page=testtools';
         $expected['mt-top-level-handle'] = 'http://example.com/wp-admin/admin.php?page=mt-top-level-handle';
-        $expected['sub-page'] = 'http://example.com/wp-admin/admin.php?page=sub-page';
-        $expected['sub-page2'] = 'http://example.com/wp-admin/admin.php?page=sub-page2';
-        $expected['not_registered'] = '';
-        $expected['With Spaces'] = 'http://example.com/wp-admin/themes.php?page=With%20Spaces';
-        $expected['testpages'] = 'http://example.com/wp-admin/edit.php?post_type=page&#038;page=testpages';
-
-        foreach ($expected as $name => $value) {
+        $expected['sub-page']            = 'http://example.com/wp-admin/admin.php?page=sub-page';
+        $expected['sub-page2']           = 'http://example.com/wp-admin/admin.php?page=sub-page2';
+        $expected['not_registered']      = '';
+        $expected['With Spaces']         = 'http://example.com/wp-admin/themes.php?page=With%20Spaces';
+        $expected['testpages']           = 'http://example.com/wp-admin/edit.php?post_type=page&#038;page=testpages';
+
+        foreach ( $expected as $name => $value ) {
             $this->assertEquals( $value, menu_page_url( $name, false ) );
         }
@@ -100 +100 @@
         $plugin_dir = WP_PLUGIN_DIR . '/list_files_test_plugin';
         @mkdir( $plugin_dir );
-        $plugin = $this->_create_plugin(null, 'list_files_test_plugin.php', $plugin_dir );
+        $plugin = $this->_create_plugin( null, 'list_files_test_plugin.php', $plugin_dir );
 
         $sub_dir = trailingslashit( dirname( $plugin[1] ) ) . 'subdir';
@@ -107 +107 @@
 
         $plugin_files = get_plugin_files( plugin_basename( $plugin[1] ) );
-        $expected = array(
+        $expected     = array(
             'list_files_test_plugin/list_files_test_plugin.php',
             'list_files_test_plugin/subdir/subfile.php',
@@ -321 +321 @@
         $plugin = $this->_create_plugin();
 
-        activate_plugin( $plugin[ 0 ] );
-        unlink( $plugin[ 1 ] );
+        activate_plugin( $plugin[0] );
+        unlink( $plugin[1] );
 
         $result = validate_active_plugins();
-        $this->assertTrue( isset( $result[ $plugin[ 0 ] ] ) );
+        $this->assertTrue( isset( $result[ $plugin[0] ] ) );
     }
 
@@ -348 +348 @@
         $plugin = $this->_create_plugin();
 
-        $uninstallable_plugins = (array) get_option( 'uninstall_plugins' );
+        $uninstallable_plugins               = (array) get_option( 'uninstall_plugins' );
         $uninstallable_plugins[ $plugin[0] ] = true;
         update_option( 'uninstall_plugins', $uninstallable_plugins );
@@ -431 +431 @@
      */
     private function _restore_mu_plugins() {
-        $mu_bu_dir = WP_CONTENT_DIR . '/mu-plugin-backup';
+        $mu_bu_dir     = WP_CONTENT_DIR . '/mu-plugin-backup';
         $files_to_move = array();
         if ( is_dir( $mu_bu_dir ) && $mu_plugins = opendir( $mu_bu_dir ) ) {
@@ -465 +465 @@
         }
 
-        foreach( _get_dropins() as $file_to_move => $v ) {
+        foreach ( _get_dropins() as $file_to_move => $v ) {
             if ( file_exists( WP_CONTENT_DIR . '/' . $file_to_move ) ) {
                 rename( WP_CONTENT_DIR . '/' . $file_to_move, $di_bu_dir . '/' . $file_to_move );
@@ -482 +482 @@
         $di_bu_dir = WP_CONTENT_DIR . '/drop-ins-backup';
 
-        foreach( _get_dropins() as $file_to_move => $v ) {
+        foreach ( _get_dropins() as $file_to_move => $v ) {
             if ( file_exists( $di_bu_dir . '/' . $file_to_move ) ) {
                 rename( $di_bu_dir . '/' . $file_to_move, WP_CONTENT_DIR . '/' . $file_to_move );