Changeset 42343 for trunk/tests/phpunit/tests/ajax/DimComment.php

Timestamp:

11/30/2017 11:09:33 PM (7 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/tests/phpunit/tests/ajax/DimComment.php (modified) (15 diffs)

trunk/tests/phpunit/tests/ajax/DimComment.php

@@ -18 +18 @@
     /**
      * List of comments
+     *
      * @var array
      */
@@ -27 +28 @@
     public function setUp() {
         parent::setUp();
-        $post_id = self::factory()->post->create();
+        $post_id         = self::factory()->post->create();
         $this->_comments = self::factory()->comment->create_post_comments( $post_id, 15 );
         $this->_comments = array_map( 'get_comment', $this->_comments );
@@ -36 +37 @@
      */
     protected function _clear_post_action() {
-        unset($_POST['id']);
-        unset($_POST['new']);
+        unset( $_POST['id'] );
+        unset( $_POST['new'] );
         $this->_last_response = '';
     }
@@ -48 +49 @@
      * Test as a privilged user (administrator)
      * Expects test to pass
+     *
      * @param mixed $comment Comment object
      * @return void
@@ -68 +70 @@
 
         // Save the comment status
-        $prev_status          = wp_get_comment_status( $comment->comment_ID );
+        $prev_status = wp_get_comment_status( $comment->comment_ID );
 
         // Make the request
@@ -88 +90 @@
         // Check the status
         $current = wp_get_comment_status( $comment->comment_ID );
-        if (in_array( $prev_status, array( 'unapproved', 'spam') ) ) {
+        if ( in_array( $prev_status, array( 'unapproved', 'spam' ) ) ) {
             $this->assertEquals( 'approved', $current );
         } else {
@@ -96 +98 @@
         // The total is calculated based on a page break -OR- a random number.  Let's look for both possible outcomes
         $comment_count = wp_count_comments( 0 );
-        $recalc_total = $comment_count->total_comments;
+        $recalc_total  = $comment_count->total_comments;
 
         // Delta is not specified, it will always be 1 lower than the request
@@ -102 +104 @@
 
         // Check for either possible total
-        $this->assertTrue( in_array( (int) $xml->response[0]->comment[0]->supplemental[0]->total[0] , array( $total, $recalc_total ) ) );
+        $this->assertTrue( in_array( (int) $xml->response[0]->comment[0]->supplemental[0]->total[0], array( $total, $recalc_total ) ) );
     }
 
@@ -108 +110 @@
      * Test as a non-privileged user (subscriber)
      * Expects test to fail
+     *
      * @param mixed $comment Comment object
      * @return void
@@ -135 +138 @@
      * Test with a bad nonce
      * Expects test to fail
+     *
      * @param mixed $comment Comment object
      * @return void
@@ -162 +166 @@
      * Test with a bad id
      * Expects test to fail
+     *
      * @return void
      */
@@ -201 +206 @@
     /**
      * Dim a comment as an administrator (expects success)
+     *
      * @return void
      */
@@ -211 +217 @@
     /**
      * Dim a comment as a subscriber (expects permission denied)
+     *
      * @return void
      */
@@ -220 +227 @@
     /**
      * Dim a comment with no id
+     *
      * @return void
      */
@@ -229 +237 @@
     /**
      * Dim a comment with a bad nonce
+     *
      * @return void
      */