Changeset 42343 for trunk/tests/phpunit/tests/auth.php

Timestamp:

11/30/2017 11:09:33 PM (7 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/tests/phpunit/tests/auth.php (modified) (10 diffs)

trunk/tests/phpunit/tests/auth.php

@@ -17 +17 @@
 
     public static function wpSetUpBeforeClass( $factory ) {
-        self::$_user = $factory->user->create_and_get( array(
-            'user_login' => 'password-tests'
-        ) );
+        self::$_user = $factory->user->create_and_get(
+            array(
+                'user_login' => 'password-tests',
+            )
+        );
 
         self::$user_id = self::$_user->ID;
@@ -49 +51 @@
         $this->assertEquals( false, wp_validate_auth_cookie( $cookie, 'logged_in' ), 'wrong auth scheme' );
 
-        $cookie = wp_generate_auth_cookie( self::$user_id, time() + 3600, 'auth' );
-        list($a, $b, $c) = explode('|', $cookie);
-        $cookie = $a . '|' . ($b + 1) . '|' . $c;
+        $cookie          = wp_generate_auth_cookie( self::$user_id, time() + 3600, 'auth' );
+        list($a, $b, $c) = explode( '|', $cookie );
+        $cookie          = $a . '|' . ( $b + 1 ) . '|' . $c;
         $this->assertEquals( false, wp_validate_auth_cookie( self::$user_id, 'auth' ), 'altered cookie' );
     }
@@ -76 +78 @@
         );
 
-        foreach( $passwords_to_test as $password_to_test ) {
+        foreach ( $passwords_to_test as $password_to_test ) {
             wp_set_password( $password_to_test, $this->user->ID );
             $authed_user = wp_authenticate( $this->user->user_login, $password_to_test );
@@ -158 +160 @@
         // A valid nonce needs to be set so the check doesn't die()
         $_REQUEST['_wpnonce'] = wp_create_nonce( -1 );
-        $result = check_admin_referer();
+        $result               = check_admin_referer();
         $this->assertSame( 1, $result );
 
@@ -172 +174 @@
         // A valid nonce needs to be set so the check doesn't die()
         $_REQUEST['_wpnonce'] = wp_create_nonce( -1 );
-        $result = check_ajax_referer();
+        $result               = check_ajax_referer();
         $this->assertSame( 1, $result );
 
@@ -231 +233 @@
         global $wpdb;
 
-        $key  = wp_generate_password( 20, false );
-        $wpdb->update( $wpdb->users, array(
-            'user_activation_key' => strtotime( '-1 hour' ) . ':' . self::$wp_hasher->HashPassword( $key ),
-        ), array(
-            'ID' => $this->user->ID,
-        ) );
+        $key = wp_generate_password( 20, false );
+        $wpdb->update(
+            $wpdb->users, array(
+                'user_activation_key' => strtotime( '-1 hour' ) . ':' . self::$wp_hasher->HashPassword( $key ),
+            ), array(
+                'ID' => $this->user->ID,
+            )
+        );
 
         // A valid key should be accepted
@@ -254 +258 @@
         // A truncated key should be rejected
         $partial = substr( $key, 0, 10 );
-        $check = check_password_reset_key( $partial, $this->user->user_login );
+        $check   = check_password_reset_key( $partial, $this->user->user_login );
         $this->assertInstanceOf( 'WP_Error', $check );
     }
@@ -264 +268 @@
         global $wpdb;
 
-        $key  = wp_generate_password( 20, false );
-        $wpdb->update( $wpdb->users, array(
-            'user_activation_key' => strtotime( '-48 hours' ) . ':' . self::$wp_hasher->HashPassword( $key ),
-        ), array(
-            'ID' => $this->user->ID,
-        ) );
+        $key = wp_generate_password( 20, false );
+        $wpdb->update(
+            $wpdb->users, array(
+                'user_activation_key' => strtotime( '-48 hours' ) . ':' . self::$wp_hasher->HashPassword( $key ),
+            ), array(
+                'ID' => $this->user->ID,
+            )
+        );
 
         // An expired but otherwise valid key should be rejected
@@ -297 +303 @@
         // A legacy user_activation_key is one without the `time()` prefix introduced in WordPress 4.3.
 
-        $key  = wp_generate_password( 20, false );
-        $wpdb->update( $wpdb->users, array(
-            'user_activation_key' => self::$wp_hasher->HashPassword( $key ),
-        ), array(
-            'ID' => $this->user->ID,
-        ) );
+        $key = wp_generate_password( 20, false );
+        $wpdb->update(
+            $wpdb->users, array(
+                'user_activation_key' => self::$wp_hasher->HashPassword( $key ),
+            ), array(
+                'ID' => $this->user->ID,
+            )
+        );
 
         // A legacy user_activation_key should not be accepted
@@ -322 +330 @@
         // A plaintext user_activation_key is one stored before hashing was introduced in WordPress 3.7.
 
-        $key  = wp_generate_password( 20, false );
-        $wpdb->update( $wpdb->users, array(
-            'user_activation_key' => $key,
-        ), array(
-            'ID' => $this->user->ID,
-        ) );
+        $key = wp_generate_password( 20, false );
+        $wpdb->update(
+            $wpdb->users, array(
+                'user_activation_key' => $key,
+            ), array(
+                'ID' => $this->user->ID,
+            )
+        );
 
         // A plaintext user_activation_key should not allow an otherwise valid key to be accepted