Changeset 42343 for trunk/tests/phpunit/tests/formatting/SanitizeFileName.php

Timestamp:

11/30/2017 11:09:33 PM (7 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/tests/phpunit/tests/formatting/SanitizeFileName.php (modified) (3 diffs)

trunk/tests/phpunit/tests/formatting/SanitizeFileName.php

@@ -12 +12 @@
 
     function test_removes_special_chars() {
-        $special_chars = array("?", "[", "]", "/", "\\", "=", "<", ">", ":", ";", ",", "'", "\"", "&", "$", "#", "*", "(", ")", "|", "~", "`", "!", "{", "}", "%", "+", chr(0));
-        $string = 'test';
-        foreach ( $special_chars as $char )
+        $special_chars = array( '?', '[', ']', '/', '\\', '=', '<', '>', ':', ';', ',', "'", '"', '&', '$', '#', '*', '(', ')', '|', '~', '`', '!', '{', '}', '%', '+', chr( 0 ) );
+        $string        = 'test';
+        foreach ( $special_chars as $char ) {
             $string .= $char;
+        }
         $string .= 'test';
         $this->assertEquals( 'testtest', sanitize_file_name( $string ) );
@@ -27 +28 @@
     function test_replace_spaces() {
         $urls = array(
-            'unencoded space.png' => 'unencoded-space.png',
-            'encoded-space.jpg' => 'encoded-space.jpg',
-            'plus+space.jpg' => 'plusspace.jpg',
+            'unencoded space.png'  => 'unencoded-space.png',
+            'encoded-space.jpg'    => 'encoded-space.jpg',
+            'plus+space.jpg'       => 'plusspace.jpg',
             'multi %20 +space.png' => 'multi-20-space.png',
         );
 
-        foreach( $urls as $test => $expected ) {
+        foreach ( $urls as $test => $expected ) {
             $this->assertEquals( $expected, sanitize_file_name( $test ) );
         }
@@ -39 +40 @@
 
     function test_replaces_any_number_of_hyphens_with_one_hyphen() {
-        $this->assertEquals("a-t-t", sanitize_file_name("a----t----t"));
+        $this->assertEquals( 'a-t-t', sanitize_file_name( 'a----t----t' ) );
     }
 
     function test_trims_trailing_hyphens() {
-        $this->assertEquals("a-t-t", sanitize_file_name("a----t----t----"));
+        $this->assertEquals( 'a-t-t', sanitize_file_name( 'a----t----t----' ) );
     }
 
     function test_replaces_any_amount_of_whitespace_with_one_hyphen() {
-        $this->assertEquals("a-t", sanitize_file_name("a          t"));
-        $this->assertEquals("a-t", sanitize_file_name("a    \n\n\nt"));
+        $this->assertEquals( 'a-t', sanitize_file_name( 'a          t' ) );
+        $this->assertEquals( 'a-t', sanitize_file_name( "a    \n\n\nt" ) );
     }