Changeset 42343 for trunk/tests/phpunit/tests/link.php

Timestamp:

11/30/2017 11:09:33 PM (7 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/tests/phpunit/tests/link.php (modified) (8 diffs)

trunk/tests/phpunit/tests/link.php

@@ -19 +19 @@
         add_filter( 'home_url', array( $this, '_get_pagenum_link_cb' ) );
         $_SERVER['REQUEST_URI'] = '/woohoo';
-        $paged = get_pagenum_link( 2 );
+        $paged                  = get_pagenum_link( 2 );
 
         remove_filter( 'home_url', array( $this, '_get_pagenum_link_cb' ) );
@@ -28 +28 @@
 
     function test_wp_get_shortlink() {
-        $post_id = self::factory()->post->create();
+        $post_id  = self::factory()->post->create();
         $post_id2 = self::factory()->post->create();
 
@@ -102 +102 @@
      */
     public function test_get_permalink_should_not_reveal_post_name_for_post_with_post_status_future() {
-        update_option( 'permalink_structure','/%year%/%monthnum%/%day%/%postname%/' );
+        update_option( 'permalink_structure', '/%year%/%monthnum%/%day%/%postname%/' );
 
         flush_rewrite_rules();
 
-        $p = self::factory()->post->create( array(
-            'post_status' => 'publish',
-            'post_date'   => strftime( '%Y-%m-%d %H:%M:%S', strtotime( '+1 day' ) )
-        ) );
+        $p = self::factory()->post->create(
+            array(
+                'post_status' => 'publish',
+                'post_date'   => strftime( '%Y-%m-%d %H:%M:%S', strtotime( '+1 day' ) ),
+            )
+        );
 
         $non_pretty_permalink = add_query_arg( 'p', $p, trailingslashit( home_url() ) );
@@ -120 +122 @@
      */
     public function test_get_permalink_should_not_reveal_post_name_for_cpt_with_post_status_future() {
-        update_option( 'permalink_structure','/%year%/%monthnum%/%day%/%postname%/' );
+        update_option( 'permalink_structure', '/%year%/%monthnum%/%day%/%postname%/' );
 
         register_post_type( 'wptests_pt', array( 'public' => true ) );
@@ -126 +128 @@
         flush_rewrite_rules();
 
-        $p = self::factory()->post->create( array(
-            'post_status' => 'future',
-            'post_type'   => 'wptests_pt',
-            'post_date'   => strftime( '%Y-%m-%d %H:%M:%S', strtotime( '+1 day' ) )
-        ) );
-
-        $non_pretty_permalink = add_query_arg( array(
-            'post_type' => 'wptests_pt',
-            'p' => $p,
-        ), trailingslashit( home_url() ) );
+        $p = self::factory()->post->create(
+            array(
+                'post_status' => 'future',
+                'post_type'   => 'wptests_pt',
+                'post_date'   => strftime( '%Y-%m-%d %H:%M:%S', strtotime( '+1 day' ) ),
+            )
+        );
+
+        $non_pretty_permalink = add_query_arg(
+            array(
+                'post_type' => 'wptests_pt',
+                'p'         => $p,
+            ), trailingslashit( home_url() )
+        );
 
         $this->assertEquals( $non_pretty_permalink, get_permalink( $p ) );
@@ -146 +152 @@
         $this->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
 
-        $attachment_id = self::factory()->attachment->create_object( 'image.jpg', 0, array(
-            'post_mime_type' => 'image/jpeg',
-            'post_type' => 'attachment',
-            'post_title' => 'An Attachment!',
-            'post_status' => 'inherit',
-        ) );
+        $attachment_id = self::factory()->attachment->create_object(
+            'image.jpg', 0, array(
+                'post_mime_type' => 'image/jpeg',
+                'post_type'      => 'attachment',
+                'post_title'     => 'An Attachment!',
+                'post_status'    => 'inherit',
+            )
+        );
 
         $attachment = get_post( $attachment_id );
@@ -172 +180 @@
         $post_id = self::factory()->post->create( array( 'post_type' => 'not_a_post_type' ) );
 
-        $attachment_id = self::factory()->attachment->create_object( 'image.jpg', $post_id, array(
-            'post_mime_type' => 'image/jpeg',
-            'post_type' => 'attachment',
-            'post_title' => 'An Attachment!',
-            'post_status' => 'inherit',
-        ) );
+        $attachment_id = self::factory()->attachment->create_object(
+            'image.jpg', $post_id, array(
+                'post_mime_type' => 'image/jpeg',
+                'post_type'      => 'attachment',
+                'post_title'     => 'An Attachment!',
+                'post_status'    => 'inherit',
+            )
+        );
 
         $attachment = get_post( $attachment_id );
@@ -183 +193 @@
         $this->assertSame( get_permalink( $post_id ) . user_trailingslashit( $attachment->post_name ), get_permalink( $attachment_id ) );
 
-        foreach( $wp_post_types as $id => $pt ) {
+        foreach ( $wp_post_types as $id => $pt ) {
             if ( 'not_a_post_type' === $pt->name ) {
                 unset( $wp_post_types[ $id ] );