Changeset 42343 for trunk/tests/phpunit/tests/xmlrpc/mw/getRecentPosts.php

Timestamp:

11/30/2017 11:09:33 PM (9 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/tests/phpunit/tests/xmlrpc/mw/getRecentPosts.php (modified) (6 diffs)

trunk/tests/phpunit/tests/xmlrpc/mw/getRecentPosts.php

@@ -8 +8 @@
 
         public static function wpSetUpBeforeClass( WP_UnitTest_Factory $factory ) {
-                self::$post_id = $factory->post->create( array(
-                        'post_type'   => 'page',
-                        'post_author' => $factory->user->create( array(
-                                'user_login' => 'author',
-                                'user_pass'  => 'author',
-                                'role'       => 'author'
-                        ) ),
-                        'post_date'   => strftime( "%Y-%m-%d %H:%M:%S", strtotime( '+1 day' ) ),
-                ) );
+                self::$post_id = $factory->post->create(
+                        array(
+                                'post_type'   => 'page',
+                                'post_author' => $factory->user->create(
+                                        array(
+                                                'user_login' => 'author',
+                                                'user_pass'  => 'author',
+                                                'role'       => 'author',
+                                        )
+                                ),
+                                'post_date'   => strftime( '%Y-%m-%d %H:%M:%S', strtotime( '+1 day' ) ),
+                        )
+                );
         }
 
@@ -47 +51 @@
                 add_theme_support( 'post-thumbnails' );
 
-                $fields = array( 'post' );
+                $fields  = array( 'post' );
                 $results = $this->myxmlrpcserver->mw_getRecentPosts( array( 1, 'author', 'author' ) );
                 $this->assertNotIXRError( $results );
 
-                foreach( $results as $result ) {
+                foreach ( $results as $result ) {
                         $post = get_post( $result['postid'] );
 
@@ -61 +65 @@
                         $this->assertInternalType( 'string', $result['link'] );
                         $this->assertInternalType( 'string', $result['permaLink'] );
-                        $this->assertInternalType( 'array',  $result['categories'] );
+                        $this->assertInternalType( 'array', $result['categories'] );
                         $this->assertInternalType( 'string', $result['mt_excerpt'] );
                         $this->assertInternalType( 'string', $result['mt_text_more'] );
@@ -95 +99 @@
 
                 // create attachment
-                $filename = ( DIR_TESTDATA.'/images/a2-small.jpg' );
+                $filename      = ( DIR_TESTDATA . '/images/a2-small.jpg' );
                 $attachment_id = self::factory()->attachment->create_upload_object( $filename, self::$post_id );
                 set_post_thumbnail( self::$post_id, $attachment_id );
@@ -102 +106 @@
                 $this->assertNotIXRError( $results );
 
-                foreach( $results as $result ) {
+                foreach ( $results as $result ) {
                         $this->assertInternalType( 'string', $result['wp_post_thumbnail'] );
                         $this->assertStringMatchesFormat( '%d', $result['wp_post_thumbnail'] );
 
-                        if( ! empty( $result['wp_post_thumbnail'] ) || $result['postid'] == self::$post_id ) {
+                        if ( ! empty( $result['wp_post_thumbnail'] ) || $result['postid'] == self::$post_id ) {
                                 $attachment_id = get_post_meta( $result['postid'], '_thumbnail_id', true );
 
@@ -122 +126 @@
                 $this->assertNotIXRError( $results );
 
-                foreach( $results as $result ) {
-                        $post = get_post( $result['postid'] );
-                        $date_gmt = strtotime( get_gmt_from_date( mysql2date( 'Y-m-d H:i:s', $post->post_date, false ), 'Ymd\TH:i:s' ) );
+                foreach ( $results as $result ) {
+                        $post              = get_post( $result['postid'] );
+                        $date_gmt          = strtotime( get_gmt_from_date( mysql2date( 'Y-m-d H:i:s', $post->post_date, false ), 'Ymd\TH:i:s' ) );
                         $date_modified_gmt = strtotime( get_gmt_from_date( mysql2date( 'Y-m-d H:i:s', $post->post_modified, false ), 'Ymd\TH:i:s' ) );