Changeset 42343 for trunk/tests/phpunit/tests/xmlrpc/wp/getTerms.php

Timestamp:

11/30/2017 11:09:33 PM (8 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/tests/phpunit/tests/xmlrpc/wp/getTerms.php (modified) (8 diffs)

trunk/tests/phpunit/tests/xmlrpc/wp/getTerms.php

@@ -43 +43 @@
 
         // make sure there's at least one category
-        $cat = wp_insert_term( 'term_' . __FUNCTION__ , 'category' );
+        $cat = wp_insert_term( 'term_' . __FUNCTION__, 'category' );
 
         $results = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', 'category' ) );
         $this->assertNotIXRError( $results );
 
-        foreach( $results as $term ) {
+        foreach ( $results as $term ) {
             $this->assertInternalType( 'int', $term['count'] );
 
@@ -66 +66 @@
 
         // create a taxonomy and some terms for it
-        $tax_name = 'wp_getTerms_custom_taxonomy';
+        $tax_name  = 'wp_getTerms_custom_taxonomy';
         $num_terms = 12;
         register_taxonomy( $tax_name, 'post' );
-        for( $i = 0; $i < $num_terms; $i++ )
+        for ( $i = 0; $i < $num_terms; $i++ ) {
             wp_insert_term( "term_{$i}", $tax_name );
-
+        }
 
         // test fetching all terms
@@ -83 +83 @@
 
         // test paged results
-        $filter = array( 'number' => 5 );
+        $filter   = array( 'number' => 5 );
         $results2 = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', $tax_name, $filter ) );
         $this->assertNotIXRError( $results );
@@ -90 +90 @@
 
         $filter['offset'] = 10;
-        $results3 = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', $tax_name, $filter ) );
+        $results3         = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', $tax_name, $filter ) );
         $this->assertNotIXRError( $results3 );
         $this->assertEquals( $num_terms - 10, count( $results3 ) );
@@ -96 +96 @@
 
         // test hide_empty (since none have been attached to posts yet, all should be hidden
-        $filter = array( 'hide_empty' => true );
+        $filter   = array( 'hide_empty' => true );
         $results4 = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', $tax_name, $filter ) );
         $this->assertNotIXRError( $results4 );
         $this->assertEquals( 0, count( $results4 ) );
 
-        unset($GLOBALS['wp_taxonomies'][$tax_name]);
+        unset( $GLOBALS['wp_taxonomies'][ $tax_name ] );
     }
 
@@ -113 +113 @@
         self::factory()->post->create_many( 3, array( 'post_category' => array( $cat2 ) ) );
 
-        $filter = array( 'orderby' => 'count', 'order' => 'DESC' );
+        $filter  = array(
+            'orderby' => 'count',
+            'order'   => 'DESC',
+        );
         $results = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', 'category', $filter ) );
         $this->assertNotIXRError( $results );
         $this->assertNotEquals( 0, count( $results ) );
 
-        foreach( $results as $term ) {
+        foreach ( $results as $term ) {
             if ( $term['term_id'] == $cat1 ) {
                 break;  // found cat1 first as expected
-            }
-            else if ( $term['term_id'] == $cat2 ) {
+            } elseif ( $term['term_id'] == $cat2 ) {
                 $this->assertFalse( false, 'Incorrect category ordering.' );
             }
@@ -131 +133 @@
         $this->make_user_by_role( 'editor' );
 
-        $name = __FUNCTION__;
+        $name    = __FUNCTION__;
         $name_id = wp_create_category( $name );
 
         // search by full name
-        $filter = array( 'search' => $name );
+        $filter  = array( 'search' => $name );
         $results = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', 'category', $filter ) );
         $this->assertNotIXRError( $results );
@@ -143 +145 @@
 
         // search by partial name
-        $filter = array( 'search' => substr( $name, 0, 10 ) );
+        $filter   = array( 'search' => substr( $name, 0, 10 ) );
         $results2 = $this->myxmlrpcserver->wp_getTerms( array( 1, 'editor', 'editor', 'category', $filter ) );
         $this->assertNotIXRError( $results2 );