Changeset 42343 for trunk/tests/phpunit/tests/xmlrpc/wp/getUsers.php

Timestamp:

11/30/2017 11:09:33 PM (5 years ago)

Author:

pento

Message:

Code is Poetry.
WordPress' code just... wasn't.
This is now dealt with.

Props jrf, pento, netweb, GaryJ, jdgrimes, westonruter, Greg Sherwood from PHPCS, and everyone who's ever contributed to WPCS and PHPCS.
Fixes #41057.

File:

• trunk/tests/phpunit/tests/xmlrpc/wp/getUsers.php (modified) (6 diffs)

trunk/tests/phpunit/tests/xmlrpc/wp/getUsers.php

@@ -45 +45 @@
     function test_invalid_role() {
         $administrator_id = $this->make_user_by_role( 'administrator' );
-        if ( is_multisite() )
+        if ( is_multisite() ) {
             grant_super_admin( $administrator_id );
+        }
 
-        $filter = array( 'role' => 'invalidrole' );
+        $filter  = array( 'role' => 'invalidrole' );
         $results = $this->myxmlrpcserver->wp_getUsers( array( 1, 'administrator', 'administrator', $filter ) );
         $this->assertIXRError( $results );
@@ -55 +56 @@
 
     function test_role_filter() {
-        $author_id = $this->make_user_by_role( 'author' );
-        $editor_id = $this->make_user_by_role( 'editor' );
+        $author_id        = $this->make_user_by_role( 'author' );
+        $editor_id        = $this->make_user_by_role( 'editor' );
         $administrator_id = $this->make_user_by_role( 'administrator' );
-        if ( is_multisite() )
+        if ( is_multisite() ) {
             grant_super_admin( $administrator_id );
+        }
 
         // test a single role ('editor')
-        $filter = array( 'role' => 'editor' );
+        $filter  = array( 'role' => 'editor' );
         $results = $this->myxmlrpcserver->wp_getUsers( array( 1, 'administrator', 'administrator', $filter ) );
         $this->assertNotIXRError( $results );
@@ -69 +71 @@
 
         // test 'authors', which should return all non-subscribers
-        $filter2 = array( 'who' => 'authors' );
+        $filter2  = array( 'who' => 'authors' );
         $results2 = $this->myxmlrpcserver->wp_getUsers( array( 1, 'administrator', 'administrator', $filter2 ) );
         $this->assertNotIXRError( $results2 );
@@ -77 +79 @@
     function test_paging_filters() {
         $administrator_id = $this->make_user_by_role( 'administrator' );
-        if ( is_multisite() )
+        if ( is_multisite() ) {
             grant_super_admin( $administrator_id );
+        }
 
         self::factory()->user->create_many( 5 );
@@ -85 +88 @@
 
         $users_found = array();
-        $page_size = 2;
+        $page_size   = 2;
 
-        $filter = array( 'number' => $page_size, 'offset' => 0 );
+        $filter = array(
+            'number' => $page_size,
+            'offset' => 0,
+        );
         do {
             $presults = $this->myxmlrpcserver->wp_getUsers( array( 1, 'administrator', 'administrator', $filter ) );
@@ -103 +109 @@
         $this->make_user_by_role( 'administrator' );
 
-        $filter = array( 'orderby' => 'email', 'order' => 'ASC' );
+        $filter  = array(
+            'orderby' => 'email',
+            'order'   => 'ASC',
+        );
         $results = $this->myxmlrpcserver->wp_getUsers( array( 1, 'administrator', 'administrator', $filter ) );
         $this->assertNotIXRError( $results );