Changeset 42349 for trunk/src/wp-admin/network/sites.php

Timestamp:

12/01/2017 11:35:31 AM (7 years ago)

Author:

DrewAPicture

Message:

Hooks: Standardize naming of dynamic hooks using values derived from superglobals to use interpolation vs concatenation.

This is a continuation of the work that happened in [38307] for #37748.

Props ramiy.
Fixes #42698.

File:

• trunk/src/wp-admin/network/sites.php (modified) (3 diffs)

trunk/src/wp-admin/network/sites.php

@@ -279 +279 @@
 $msg = '';
 if ( isset( $_GET['updated'] ) ) {
-    switch ( $_GET['updated'] ) {
+    $action = $_GET['updated'];
+
+    switch ( $action ) {
         case 'all_notspam':
             $msg = __( 'Sites removed from spam.' );
@@ -315 +317 @@
         default:
             /**
-             * Filters a specific, non-default site-updated message in the Network admin.
-             *
-             * The dynamic portion of the hook name, `$_GET['updated']`, refers to the
-             * non-default site update action.
+             * Filters a specific, non-default, site-updated message in the Network admin.
+             *
+             * The dynamic portion of the hook name, `$action`, refers to the non-default
+             * site update action.
              *
              * @since 3.1.0
@@ -324 +326 @@
              * @param string $msg The update message. Default 'Settings saved'.
              */
-            $msg = apply_filters( 'network_sites_updated_message_' . $_GET['updated'], __( 'Settings saved.' ) );
+            $msg = apply_filters( "network_sites_updated_message_{$action}", __( 'Settings saved.' ) );
             break;
     }