Changeset 42369

Timestamp:

12/04/2017 09:54:15 PM (3 years ago)

Author:

boonebgorges

Message:

Don't do a strict taxonomy check in get_category_link().

Prior to version 4.9, a quirk in the implementation of get_term() caused
get_category_link( 123 ) to fetch the taxonomy archive link for term 123
even if 123 is not in the 'category' taxonomy. The quirk was fixed in [40979];
see #40671. This bugfix introduced a regression for theme authors who were
expecting the old behavior.

By lifting the 'category' restriction, we allow the template function to work
in the old way.

Merges [42364], [42365] to the 4.9 branch.

Fixes #42717. See #42771.

Location:

branches/4.9

Files:

• . (modified) (1 prop)
• src/wp-includes/category-template.php (modified) (1 diff)
• tests/phpunit/tests/category/getCategoryLink.php (copied) (copied from trunk/tests/phpunit/tests/category/getCategoryLink.php) (2 diffs)

branches/4.9/src/wp-includes/category-template.php

@@ -21 +21 @@
         $category = (int) $category;
 
-    $category = get_term_link( $category, 'category' );
+    $category = get_term_link( $category );
 
     if ( is_wp_error( $category ) )

branches/4.9/tests/phpunit/tests/category/getCategoryLink.php

@@ -18 +18 @@
      * @ticket 42771
      */
-    public function test_should_return_link_for_term_from_another_category_on_primed_cache() {
+    public function test_should_return_link_for_term_from_another_taxonomy_on_primed_cache() {
         register_taxonomy( 'wptests_tax', 'post' );
 
@@ -37 +37 @@
      * @ticket 42771
      */
-    public function test_should_return_link_for_term_from_another_category_on_empty_cache() {
+    public function test_should_return_link_for_term_from_another_taxonomy_on_empty_cache() {
         register_taxonomy( 'wptests_tax', 'post' );