Changeset 42380 for trunk/src/wp-includes/post.php

Timestamp:

12/09/2017 10:50:13 PM (7 years ago)

Author:

johnbillion

Message:

Role/Capability: When checking capabilities before setting a post slug, ensure the correct post type capabilities are used.

Previously, only the publish_posts capability was checked. Now, the correct meta or primitive capability for the post type is used where appropriate.

Props peterwilsoncc

Fixes #42464

File:

• trunk/src/wp-includes/post.php (modified) (1 diff)

trunk/src/wp-includes/post.php

@@ -3305 +3305 @@
     }
 
-    // Don't allow contributors to set the post slug for pending review posts.
-    if ( 'pending' == $post_status && ! current_user_can( 'publish_posts' ) ) {
+    /*
+     * Don't allow contributors to set the post slug for pending review posts.
+     *
+     * For new posts check the primitive capability, for updates check the meta capability.
+     */
+    $post_type_object = get_post_type_object( $post_type );
+
+    if ( ! $update && 'pending' === $post_status && ! current_user_can( $post_type_object->cap->publish_posts ) ) {
+        $post_name = '';
+    } elseif ( $update && 'pending' === $post_status && ! current_user_can( 'publish_post', $post_ID ) ) {
         $post_name = '';
     }