Changeset 42381 for trunk/tests/phpunit/tests/basic.php

Timestamp:

12/09/2017 11:08:24 PM (9 years ago)

Author:

johnbillion

Message:

Build/Test tools: Remove unnecessary PHP functionality tests from the test suite.

Props Frank Klein
Fixes #42277

File:

• trunk/tests/phpunit/tests/basic.php (modified) (2 diffs)

trunk/tests/phpunit/tests/basic.php

@@ -38 +38 @@
                 $node = $package_json['engines']['node'];
                 $this->assertRegExp( '~^=?\d+\.\d+\.\d+$~', $node, "package.json's node version cannot be a range." );
-        }
-
-        // two tests for a lame bug in PHPUnit that broke the $GLOBALS reference
-        function test_globals() {
-                global $test_foo;
-                $test_foo = array( 'foo', 'bar', 'baz' );
-
-                function test_globals_foo() {
-                        unset( $GLOBALS['test_foo'][1] );
-                }
-
-                test_globals_foo();
-
-                $this->assertEquals(
-                        $test_foo, array(
-                                0 => 'foo',
-                                2 => 'baz',
-                        )
-                );
-                $this->assertEquals( $test_foo, $GLOBALS['test_foo'] );
-        }
-
-        function test_globals_bar() {
-                global $test_bar;
-                $test_bar = array( 'a', 'b', 'c' );
-                $this->assertEquals( $test_bar, $GLOBALS['test_bar'] );
         }
 
@@ -111 +85 @@
                 $this->assertEquals( $expected, mask_input_value( $in ) );
         }
-
-        /**
-         * @ticket 17884
-         */
-        function test_setting_nonexistent_arrays() {
-                $page  = 1;
-                $field = 'settings';
-
-                $empty_array[ $page ][ $field ] = 'foo';
-
-                // Assertion not strictly needed; we mainly want to show that a notice is not thrown.
-                unset( $empty_array[ $page ]['bar']['baz'] );
-                $this->assertFalse( isset( $empty_array[ $page ]['bar']['baz'] ) );
-        }
-
-        function test_magic_getter() {
-                $basic = new Basic_Object();
-
-                $this->assertEquals( 'bar', $basic->foo );
-        }
-
-        function test_subclass_magic_getter() {
-                $basic = new Basic_Subclass();
-
-                $this->assertEquals( 'bar', $basic->foo );
-        }
-
-        function test_call_method() {
-                $basic = new Basic_Object();
-
-                $this->assertEquals( 'maybe', $basic->callMe() );
-        }
-
-        function test_subclass_call_method() {
-                $basic = new Basic_Subclass();
-
-                $this->assertEquals( 'maybe', $basic->callMe() );
-        }
-
-        function test_subclass_isset() {
-                $basic = new Basic_Subclass();
-
-                $this->assertTrue( isset( $basic->foo ) );
-        }
-
-        function test_subclass_unset() {
-                $basic = new Basic_Subclass();
-
-                unset( $basic->foo );
-
-                $this->assertFalse( isset( $basic->foo ) );
-        }
-
-        function test_switch_order() {
-                $return = $this->_switch_order_helper( 1 );
-                $this->assertEquals( 'match', $return );
-        }
-
-        function _switch_order_helper( $var ) {
-                $return = 'no match';
-                switch ( $var ) {
-                        default:
-                                break;
-                        case 1:
-                                $return = 'match';
-                                break;
-                }
-
-                return $return;
-        }
 }