Changeset 42382 for trunk/tests/phpunit/tests/post/thumbnails.php

Timestamp:

12/10/2017 12:30:32 AM (7 years ago)

Author:

johnbillion

Message:

Build/Test tools: Switch to PHPUnit's expectOutputString() method instead of manually using output buffers for output assertions.

Props birgire
Fixes #42098

File:

• trunk/tests/phpunit/tests/post/thumbnails.php (modified) (4 diffs)

trunk/tests/phpunit/tests/post/thumbnails.php

@@ -142 +142 @@
         set_post_thumbnail( $post_id, $attachment_id );
 
-        ob_start();
+        $this->expectOutputString( $caption );
         the_post_thumbnail_caption( $post_id );
-
-        $this->assertEquals( $caption, ob_get_clean() );
     }
 
@@ -167 +165 @@
 
     function test_the_post_thumbnail() {
-        ob_start();
+
+        $this->expectOutputString( '' );
         the_post_thumbnail();
-        $actual = ob_get_clean();
-
-        $this->assertEquals( '', $actual );
-
-        $GLOBALS['post'] = self::$post;
-
-        ob_start();
+
+        $GLOBALS['post'] = self::$post;
+
+        $this->expectOutputString( '' );
         the_post_thumbnail();
-        $actual = ob_get_clean();
-
-        $this->assertEquals( '', $actual );
 
         set_post_thumbnail( self::$post, self::$attachment_id );
@@ -189 +182 @@
         );
 
-        ob_start();
+        $this->expectOutputString( $expected );
         the_post_thumbnail();
-        $actual = ob_get_clean();
-
-        $this->assertEquals( $expected, $actual );
     }
 
@@ -234 +224 @@
         $GLOBALS['post'] = self::$post;
 
-        ob_start();
+        $this->expectOutputString( '' );
         the_post_thumbnail_url();
-        $actual = ob_get_clean();
-
-        $this->assertEmpty( $actual );
-
-        ob_start();
+
+        set_post_thumbnail( self::$post, self::$attachment_id );
+
+        $this->expectOutputString( wp_get_attachment_url( self::$attachment_id ) );
         the_post_thumbnail_url();
-        $actual = ob_get_clean();
-
-        $this->assertEmpty( $actual );
-
-        set_post_thumbnail( self::$post, self::$attachment_id );
-
-        ob_start();
-        the_post_thumbnail_url();
-        $actual = ob_get_clean();
-
-        $this->assertEquals( wp_get_attachment_url( self::$attachment_id ), $actual );
     }