Changeset 42404 for trunk/src/wp-admin/includes/image-edit.php

Timestamp:

12/15/2017 10:02:02 PM (7 years ago)

Author:

adamsilverstein

Message:

Media: improve flows for cropping on attachment details screen.

On the "Attachment Details" screen:

• The crop button is always 'enabled'.
• Clicking the crop button with no selection selects the entire image.
• Clicking the crop button with the entire image selected doesn't do anything.
• Clicking the crop button with a selection crops as expected.

Props sonjanyc, afercia, mikeschroder.
Fixes #30155.

File:

• trunk/src/wp-admin/includes/image-edit.php (modified) (1 diff)

trunk/src/wp-admin/includes/image-edit.php

@@ -191 +191 @@
         <?php echo $note; ?>
         <div class="imgedit-menu wp-clearfix">
-            <button type="button" onclick="imageEdit.crop(<?php echo "$post_id, '$nonce'"; ?>, this)" class="imgedit-crop button disabled" disabled><span class="screen-reader-text"><?php esc_html_e( 'Crop' ); ?></span></button>
+            <button type="button" onclick="imageEdit.handleCropToolClick( <?php echo "$post_id, '$nonce'"; ?>, this )" class="imgedit-crop button disabled" disabled><span class="screen-reader-text"><?php esc_html_e( 'Crop' ); ?></span></button>
                                                                         <?php