Changeset 42429

Timestamp:

01/08/2018 10:35:13 AM (6 years ago)

Author:

pento

Message:

Formatting: Fix capital_P_dangit() not capital P-ing, dangit.

Unfortunately, in my overzealous desire to fix all the un-capitalised Ps, [42343] capitalled some Ps that intentionally should not be capitals.

This commit fixes the incorrectly capitalling of Ps, as well as including unit tests and PHPCS instructions to ensure we never capitulate to capitalisationing them again.

Props superdav42.
Fixes #43040.
Fixes #43041.

Location:

trunk

Files:

• src/wp-includes/formatting.php (modified) (3 diffs)
• tests/phpunit/tests/formatting/CapitalPDangit.php (added)

trunk/src/wp-includes/formatting.php

@@ -5078 +5078 @@
 }
 
-/**
- * Forever eliminate "WordPress" from the planet (or at least the little bit we can influence).
+// phpcs:disable WordPress.WP.CapitalPDangit.Misspelled, WordPress.NamingConventions.ValidFunctionName.FunctionNameInvalid -- 8-)
+/**
+ * Forever eliminate "Wordpress" from the planet (or at least the little bit we can influence).
  *
  * Violating our coding standards for a good function name.
@@ -5094 +5095 @@
     $current_filter = current_filter();
     if ( 'the_title' === $current_filter || 'wp_title' === $current_filter ) {
-        return str_replace( 'WordPress', 'WordPress', $text );
+        return str_replace( 'Wordpress', 'WordPress', $text );
     }
     // Still here? Use the more judicious replacement
@@ -5107 +5108 @@
     );
 }
+// phpcs:enable
 
 /**