Changeset 42430

Timestamp:

01/08/2018 08:20:00 PM (7 years ago)

Author:

azaozz

Message:

Editor: ensure there is a selection before getting the caret position. Fixes a bug in Firefox when there is no selection for a hidden element.

Props johnschulz, azaozz.

Fixes #43012 for trunk.

File:

• trunk/src/wp-admin/js/editor.js (modified) (1 diff)

trunk/src/wp-admin/js/editor.js

@@ -696 +696 @@
         function findBookmarkedPosition( editor ) {
             // Get the TinyMCE `window` reference, since we need to access the raw selection.
-            var TinyMCEWIndow = editor.getWin(),
-                selection = TinyMCEWIndow.getSelection();
-
-            if ( selection.rangeCount <= 0 ) {
+            var TinyMCEWindow = editor.getWin(),
+                selection = TinyMCEWindow.getSelection();
+
+            if ( ! selection || selection.rangeCount < 1 ) {
                 // no selection, no need to continue.
                 return;