Changeset 42493

Timestamp:

01/16/2018 08:57:09 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Plugins: Fix the plugin details modal "Close" button after [42443].

Props rinkuyadav999.
Merges [42491] to the 4.9 branch.
Fixes #43082.

Location:

branches/4.9

Files:

• . (modified) (1 prop)
• src/wp-admin/js/plugin-install.js (modified) (1 diff)

branches/4.9/src/wp-admin/js/plugin-install.js

@@ -149 +149 @@
     /*
      * Open the Plugin details modal. The event is delegated to get also the links
-     * in the plugins search tab, after the AJAX search rebuilds the HTML.
-     */
-    $( 'body' ).on( 'click', '.thickbox.open-plugin-details-modal', function( e ) {
+     * in the plugins search tab, after the AJAX search rebuilds the HTML. It's
+     * delegated on the closest ancestor and not on the body to avoid conflicts
+     * with other handlers, see Trac ticket #43082.
+     */
+    $( '.wrap' ).on( 'click', '.thickbox.open-plugin-details-modal', function( e ) {
         // The `data-title` attribute is used only in the Plugin screens.
         var title = $( this ).data( 'title' ) ? plugininstallL10n.plugin_information + ' ' + $( this ).data( 'title' ) : plugininstallL10n.plugin_modal_label;