Changeset 42525

Timestamp:

01/17/2018 07:15:57 AM (6 years ago)

Author:

SergeyBiryukov

Message:

Media: In _wp_handle_upload(), check if the file was properly uploaded before checking its size.

Props achbed, dglingren.
Fixes #39522.

File:

• trunk/src/wp-admin/includes/file.php (modified) (2 diffs)

trunk/src/wp-admin/includes/file.php

@@ -779 +779 @@
     }
 
+    // A properly uploaded file will pass this test. There should be no reason to override this one.
+    $test_uploaded_file = 'wp_handle_upload' === $action ? @ is_uploaded_file( $file['tmp_name'] ) : @ is_readable( $file['tmp_name'] );
+    if ( ! $test_uploaded_file ) {
+        return call_user_func_array( $upload_error_handler, array( &$file, __( 'Specified file failed upload test.' ) ) );
+    }
+
     $test_file_size = 'wp_handle_upload' === $action ? $file['size'] : filesize( $file['tmp_name'] );
     // A non-empty file will pass this test.
@@ -788 +794 @@
         }
         return call_user_func_array( $upload_error_handler, array( &$file, $error_msg ) );
-    }
-
-    // A properly uploaded file will pass this test. There should be no reason to override this one.
-    $test_uploaded_file = 'wp_handle_upload' === $action ? @ is_uploaded_file( $file['tmp_name'] ) : @ is_file( $file['tmp_name'] );
-    if ( ! $test_uploaded_file ) {
-        return call_user_func_array( $upload_error_handler, array( &$file, __( 'Specified file failed upload test.' ) ) );
     }