Changeset 42526

Timestamp:

01/18/2018 05:14:28 AM (9 years ago)

Author:

dd32

Message:

Tests: Remove redundant assertEquals() calls in listFilter tests.

As these tests are already validating that two arrays match, checking that the counts also match before is redundant and makes it harder to debug when the test fails.

See #16895

File:

• trunk/tests/phpunit/tests/functions/listFilter.php (modified) (6 diffs)

trunk/tests/phpunit/tests/functions/listFilter.php

@@ -84 +84 @@
                         ), 'AND', 'name'
                 );
-                $this->assertEquals( 2, count( $list ) );
                 $this->assertEquals(
                         array(
@@ -100 +99 @@
                         ), 'OR', 'name'
                 );
-                $this->assertEquals( 2, count( $list ) );
                 $this->assertEquals(
                         array(
@@ -116 +114 @@
                         ), 'NOT', 'name'
                 );
-                $this->assertEquals( 1, count( $list ) );
                 $this->assertEquals( array( 'baz' => 'baz' ), $list );
         }
@@ -248 +245 @@
         function test_filter_object_list_nested_array_and_field() {
                 $list = wp_filter_object_list( $this->object_list, array( 'field4' => array( 'blue' ) ), 'AND', 'name' );
-                $this->assertEquals( 1, count( $list ) );
                 $this->assertEquals( array( 'baz' => 'baz' ), $list );
         }
@@ -254 +250 @@
         function test_filter_object_list_nested_array_not_field() {
                 $list = wp_filter_object_list( $this->object_list, array( 'field4' => array( 'green' ) ), 'NOT', 'name' );
-                $this->assertEquals( 2, count( $list ) );
                 $this->assertEquals(
                         array(
@@ -270 +265 @@
                         ), 'OR', 'name'
                 );
-                $this->assertEquals( 2, count( $list ) );
                 $this->assertEquals(
                         array(