Changeset 42527 for trunk/src/wp-includes/class-wp-list-util.php

Timestamp:

01/18/2018 05:17:23 AM (9 years ago)

Author:

dd32

Message:

General: Allow wp_list_pluck() to operate on arrays of references without overwriting the referenced items.

Fixes #16895.

File:

• trunk/src/wp-includes/class-wp-list-util.php (modified) (3 diffs)

trunk/src/wp-includes/class-wp-list-util.php

@@ -141 +141 @@
          */
         public function pluck( $field, $index_key = null ) {
+                $newlist = array();
+
                 if ( ! $index_key ) {
                         /*
@@ -148 +150 @@
                         foreach ( $this->output as $key => $value ) {
                                 if ( is_object( $value ) ) {
-                                        $this->output[ $key ] = $value->$field;
+                                        $newlist[ $key ] = $value->$field;
                                 } else {
-                                        $this->output[ $key ] = $value[ $field ];
-                                }
-                        }
+                                        $newlist[ $key ] = $value[ $field ];
+                                }
+                        }
+
+                        $this->output = $newlist;
+
                         return $this->output;
                 }
@@ -160 +165 @@
                  * to the end of the stack. This is how array_column() behaves.
                  */
-                $newlist = array();
                 foreach ( $this->output as $value ) {
                         if ( is_object( $value ) ) {