Changeset 42581 for trunk/tests/phpunit/tests/post/query.php

Timestamp:

01/24/2018 01:20:24 AM (4 years ago)

Author:

jorbin

Message:

Query: Fix warning on counting non countable

Adds tests to continue the behavior for both null and strings.

See ​https://wiki.php.net/rfc/counting_non_countables for information on the PHP change.

Fixes #42860.
Props janak007 and ayeshrajans for initial patches.

File:

• trunk/tests/phpunit/tests/post/query.php (modified) (1 diff)

trunk/tests/phpunit/tests/post/query.php

@@ -643 +643 @@
         $this->assertEquals( 2, $q->max_num_pages );
     }
+
+    /**
+     * @ticket 42860
+     */
+    public function test_set_found_posts_fields_posts_is_string() {
+        $q = new WP_Query(
+            array(
+                'post_type'      => 'wptests_pt',
+                'posts_per_page' => 1,
+            )
+        );
+
+        $q->posts = "To life, to life, l'chaim";
+
+        $methd = new \ReflectionMethod( 'WP_Query', 'set_found_posts' );
+        $methd->setAccessible( true );
+        $methd->invoke( $q, array( 'no_found_rows' => false ), array() );
+
+        $this->assertEquals( 1, $q->found_posts );
+    }
+
+    /**
+     * @ticket 42860
+     */
+    public function test_set_found_posts_fields_posts_is_null() {
+        $q = new WP_Query(
+            array(
+                'post_type'      => 'wptests_pt',
+                'posts_per_page' => 1,
+            )
+        );
+
+        $q->posts = null;
+
+        $methd = new \ReflectionMethod( 'WP_Query', 'set_found_posts' );
+        $methd->setAccessible( true );
+        $methd->invoke( $q, array( 'no_found_rows' => false ), array() );
+
+        $this->assertEquals( 0, $q->found_posts );
+    }
+
 }