Changeset 42594

Timestamp:

01/24/2018 08:51:06 PM (7 years ago)

Author:

jorbin

Message:

Query: Improve tests for set_found_posts dealing with non arrays

Use a data provider and include tests for false and ''.

Previous: [42581] [42585]

See #42860

File:

• trunk/tests/phpunit/tests/post/query.php (modified) (3 diffs)

trunk/tests/phpunit/tests/post/query.php

@@ -644 +644 @@
     }
 
+    public function set_found_posts_provider() {
+        // count return 0 for null, but 1 for other data you may not expect
+        return array(
+            array( null, 0 ),
+            array( '', 1 ),
+            array( "To life, to life, l'chaim", 1 ),
+            array( false, 1 ),
+        );
+    }
+
     /**
      * @ticket 42860
-     */
-    public function test_set_found_posts_fields_posts_is_string() {
+     *
+     * @dataProvider set_found_posts_provider
+     */
+    public function test_set_found_posts_not_posts_as_an_array( $posts, $expected ) {
         if ( version_compare( PHP_VERSION, '5.3', '<' ) ) {
             $this->markTestSkipped( 'ReflectionMethod::setAccessible is only available in PHP 5.3+' );
@@ -660 +672 @@
         );
 
-        $q->posts = "To life, to life, l'chaim";
+        $q->posts = $posts;
 
         $methd = new \ReflectionMethod( 'WP_Query', 'set_found_posts' );
@@ -666 +678 @@
         $methd->invoke( $q, array( 'no_found_rows' => false ), array() );
 
-        $this->assertEquals( 1, $q->found_posts );
-    }
-
-    /**
-     * @ticket 42860
-     */
-    public function test_set_found_posts_fields_posts_is_null() {
-        if ( version_compare( PHP_VERSION, '5.3', '<' ) ) {
-            $this->markTestSkipped( 'ReflectionMethod::setAccessible is only available in PHP 5.3+' );
-            return;
-        }
-
-        $q = new WP_Query(
-            array(
-                'post_type'      => 'wptests_pt',
-                'posts_per_page' => 1,
-            )
-        );
-
-        $q->posts = null;
-
-        $methd = new \ReflectionMethod( 'WP_Query', 'set_found_posts' );
-        $methd->setAccessible( true );
-        $methd->invoke( $q, array( 'no_found_rows' => false ), array() );
-
-        $this->assertEquals( 0, $q->found_posts );
+        $this->assertEquals( $expected, $q->found_posts );
     }