Changeset 42692

Timestamp:

02/11/2018 02:52:03 PM (7 years ago)

Author:

SergeyBiryukov

Message:

Media: Make sure $caption_id does not depend on an undefined variable.

See #34595.

File:

• trunk/src/wp-includes/media.php (modified) (1 diff)

trunk/src/wp-includes/media.php

@@ -1557 +1557 @@
     }
 
+    $caption_id = '';
+
     if ( ! empty( $atts['id'] ) ) {
         $att_id     = esc_attr( sanitize_html_class( $atts['id'] ) );
         $atts['id'] = 'id="' . $att_id . '" ';
-    }
-
-    $caption_id = 'caption-' . str_replace( '_', '-', $att_id );
+        $caption_id = 'caption-' . str_replace( '_', '-', $att_id );
+    }
 
     $class = trim( 'wp-caption ' . $atts['align'] . ' ' . $atts['class'] );