Changeset 42723 for trunk/src/wp-includes/load.php

Timestamp:

02/21/2018 02:58:14 PM (7 years ago)

Author:

markjaquith

Message:

Cache API: Allow external object caches to gracefully degrade to the default object cache.

Rework logic for how external object caches are detected, so that if
an external cache does not define a wp_cache_init(), the built-in
object cache will be used.

Object caches can now wrap their entire contents in logic checks. So a
Redis caching backend could make sure that the Redis PHP class is
available before defining all the caching functions. And if Redis is
not available, the site doesn't break or throw errors or think it is
using caching when it isn't. This is particularly useful for doing
local development, where you might want to develop on a site without
running Memcache or Redis like you are in production.

• Accounts for multisite, which may re-initialize the object cache

multiple times.

• Accounts for object caches that may include object-cache.php during

advanced-cache.php (before WP loads it).

Props jtsternberg, markjaquith.
Fixes #22661.

File:

• trunk/src/wp-includes/load.php (modified) (2 diffs)

trunk/src/wp-includes/load.php

@@ -531 +531 @@
 function wp_start_object_cache() {
     global $wp_filter;
-
-    $first_init = false;
-    if ( ! function_exists( 'wp_cache_init' ) ) {
-        if ( file_exists( WP_CONTENT_DIR . '/object-cache.php' ) ) {
-            require_once( WP_CONTENT_DIR . '/object-cache.php' );
-            if ( function_exists( 'wp_cache_init' ) ) {
-                wp_using_ext_object_cache( true );
+    static $first_init = true;
+
+    // Only perform the following checks once.
+    if ( $first_init ) {
+        if ( ! function_exists( 'wp_cache_init' ) ) {
+            /*
+             * This is the normal situation. First-run of this function. No
+             * caching backend has been loaded.
+             *
+             * We try to load a custom caching backend, and then, if it
+             * results in a wp_cache_init() function existing, we note
+             * that an external object cache is being used.
+             */
+            if ( file_exists( WP_CONTENT_DIR . '/object-cache.php' ) ) {
+                require_once( WP_CONTENT_DIR . '/object-cache.php' );
+                if ( function_exists( 'wp_cache_init' ) ) {
+                    wp_using_ext_object_cache( true );
+                }
+
+                // Re-initialize any hooks added manually by object-cache.php
+                if ( $wp_filter ) {
+                    $wp_filter = WP_Hook::build_preinitialized_hooks( $wp_filter );
+                }
             }
-
-            // Re-initialize any hooks added manually by object-cache.php
-            if ( $wp_filter ) {
-                $wp_filter = WP_Hook::build_preinitialized_hooks( $wp_filter );
-            }
-        }
-
-        $first_init = true;
-    } elseif ( ! wp_using_ext_object_cache() && file_exists( WP_CONTENT_DIR . '/object-cache.php' ) ) {
-        /*
-         * Sometimes advanced-cache.php can load object-cache.php before
-         * it is loaded here. This breaks the function_exists check above
-         * and can result in `$_wp_using_ext_object_cache` being set
-         * incorrectly. Double check if an external cache exists.
-         */
-        wp_using_ext_object_cache( true );
+        } elseif ( ! wp_using_ext_object_cache() && file_exists( WP_CONTENT_DIR . '/object-cache.php' ) ) {
+            /*
+             * Sometimes advanced-cache.php can load object-cache.php before
+             * this function is run. This breaks the function_exists() check
+             * above and can result in wp_using_ext_object_cache() returning
+             * false when actually an external cache is in use.
+             */
+            wp_using_ext_object_cache( true );
+        }
     }
 
@@ -576 +585 @@
         wp_cache_add_non_persistent_groups( array( 'counts', 'plugins' ) );
     }
+
+    $first_init = false;
 }