Make WordPress Core


Ignore:
Timestamp:
02/21/2018 04:24:30 PM (7 years ago)
Author:
SergeyBiryukov
Message:

Tests: Replace use of $this->server with rest_get_server() for better memory recycling.

Props danielbachhuber.
Fixes #41641.

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/tests/phpunit/tests/rest-api/rest-settings-controller.php

    r42423 r42724  
    4040
    4141    public function test_register_routes() {
    42         $routes = $this->server->get_routes();
     42        $routes = rest_get_server()->get_routes();
    4343        $this->assertArrayHasKey( '/wp/v2/settings', $routes );
    4444    }
     
    4848        wp_set_current_user( self::$administrator );
    4949        $request  = new WP_REST_Request( 'GET', '/wp/v2/settings/title' );
    50         $response = $this->server->dispatch( $request );
     50        $response = rest_get_server()->dispatch( $request );
    5151        $this->assertEquals( 404, $response->get_status() );
    5252    }
     
    5757    public function test_get_item_is_not_public_not_authenticated() {
    5858        $request  = new WP_REST_Request( 'GET', '/wp/v2/settings' );
    59         $response = $this->server->dispatch( $request );
     59        $response = rest_get_server()->dispatch( $request );
    6060        $this->assertEquals( 401, $response->get_status() );
    6161    }
     
    6464        wp_set_current_user( self::$author );
    6565        $request  = new WP_REST_Request( 'GET', '/wp/v2/settings' );
    66         $response = $this->server->dispatch( $request );
     66        $response = rest_get_server()->dispatch( $request );
    6767        $this->assertEquals( 403, $response->get_status() );
    6868    }
     
    7171        wp_set_current_user( self::$administrator );
    7272        $request  = new WP_REST_Request( 'GET', '/wp/v2/settings' );
    73         $response = $this->server->dispatch( $request );
     73        $response = rest_get_server()->dispatch( $request );
    7474        $data     = $response->get_data();
    7575        $actual   = array_keys( $data );
     
    108108        update_option( 'posts_per_page', 'invalid_number' ); // this is cast to (int) 1
    109109        $request  = new WP_REST_Request( 'GET', '/wp/v2/settings' );
    110         $response = $this->server->dispatch( $request );
     110        $response = rest_get_server()->dispatch( $request );
    111111        $data     = $response->get_data();
    112112
     
    132132
    133133        $request  = new WP_REST_Request( 'GET', '/wp/v2/settings' );
    134         $response = $this->server->dispatch( $request );
     134        $response = rest_get_server()->dispatch( $request );
    135135        $data     = $response->get_data();
    136136
     
    142142
    143143        $request  = new WP_REST_Request( 'GET', '/wp/v2/settings' );
    144         $response = $this->server->dispatch( $request );
     144        $response = rest_get_server()->dispatch( $request );
    145145        $data     = $response->get_data();
    146146        $this->assertEquals( 'validvalue2', $data['mycustomsettinginrest'] );
     
    169169        update_option( 'mycustomsetting', array( '1', '2' ) );
    170170        $request  = new WP_REST_Request( 'GET', '/wp/v2/settings' );
    171         $response = $this->server->dispatch( $request );
     171        $response = rest_get_server()->dispatch( $request );
    172172        $data     = $response->get_data();
    173173        $this->assertEquals( array( 1, 2 ), $data['mycustomsetting'] );
     
    176176        update_option( 'mycustomsetting', array() );
    177177        $request  = new WP_REST_Request( 'GET', '/wp/v2/settings' );
    178         $response = $this->server->dispatch( $request );
     178        $response = rest_get_server()->dispatch( $request );
    179179        $data     = $response->get_data();
    180180        $this->assertEquals( array(), $data['mycustomsetting'] );
     
    183183        update_option( 'mycustomsetting', array( array( 1 ) ) );
    184184        $request  = new WP_REST_Request( 'GET', '/wp/v2/settings' );
    185         $response = $this->server->dispatch( $request );
     185        $response = rest_get_server()->dispatch( $request );
    186186        $data     = $response->get_data();
    187187        $this->assertEquals( null, $data['mycustomsetting'] );
     
    190190        delete_option( 'mycustomsetting' );
    191191        $request  = new WP_REST_Request( 'GET', '/wp/v2/settings' );
    192         $response = $this->server->dispatch( $request );
     192        $response = rest_get_server()->dispatch( $request );
    193193        $data     = $response->get_data();
    194194        $this->assertEquals( null, $data['mycustomsetting'] );
     
    217217
    218218        // We have to re-register the route, as the args changes based off registered settings.
    219         $this->server->override_by_default = true;
     219        rest_get_server()->override_by_default = true;
    220220        $this->endpoint->register_routes();
    221221
     
    223223        update_option( 'mycustomsetting', array( 'a' => '1' ) );
    224224        $request  = new WP_REST_Request( 'GET', '/wp/v2/settings' );
    225         $response = $this->server->dispatch( $request );
     225        $response = rest_get_server()->dispatch( $request );
    226226        $data     = $response->get_data();
    227227        $this->assertEquals( array( 'a' => 1 ), $data['mycustomsetting'] );
     
    230230        update_option( 'mycustomsetting', array() );
    231231        $request  = new WP_REST_Request( 'GET', '/wp/v2/settings' );
    232         $response = $this->server->dispatch( $request );
     232        $response = rest_get_server()->dispatch( $request );
    233233        $data     = $response->get_data();
    234234        $this->assertEquals( array(), $data['mycustomsetting'] );
     
    242242        );
    243243        $request  = new WP_REST_Request( 'GET', '/wp/v2/settings' );
    244         $response = $this->server->dispatch( $request );
     244        $response = rest_get_server()->dispatch( $request );
    245245        $data     = $response->get_data();
    246246        $this->assertEquals( null, $data['mycustomsetting'] );
     
    284284
    285285        $request  = new WP_REST_Request( 'GET', '/wp/v2/settings' );
    286         $response = $this->server->dispatch( $request );
     286        $response = rest_get_server()->dispatch( $request );
    287287        $data     = $response->get_data();
    288288
     
    318318
    319319        $request  = new WP_REST_Request( 'GET', '/wp/v2/settings' );
    320         $response = $this->server->dispatch( $request );
     320        $response = rest_get_server()->dispatch( $request );
    321321        $data     = $response->get_data();
    322322        $this->assertEquals( null, $data['mycustomsettinginrest'] );
     
    342342
    343343        $request  = new WP_REST_Request( 'GET', '/wp/v2/settings' );
    344         $response = $this->server->dispatch( $request );
     344        $response = rest_get_server()->dispatch( $request );
    345345        $data     = $response->get_data();
    346346        $this->assertEquals( null, $data['mycustomsettinginrest'] );
     
    356356        $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
    357357        $request->set_param( 'title', 'The new title!' );
    358         $response = $this->server->dispatch( $request );
     358        $response = rest_get_server()->dispatch( $request );
    359359        $data     = $response->get_data();
    360360
     
    389389
    390390        // We have to re-register the route, as the args changes based off registered settings.
    391         $this->server->override_by_default = true;
     391        rest_get_server()->override_by_default = true;
    392392        $this->endpoint->register_routes();
    393393        wp_set_current_user( self::$administrator );
     
    395395        $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
    396396        $request->set_param( 'mycustomsetting', array( '1', '2' ) );
    397         $response = $this->server->dispatch( $request );
     397        $response = rest_get_server()->dispatch( $request );
    398398        $data     = $response->get_data();
    399399        $this->assertEquals( array( 1, 2 ), $data['mycustomsetting'] );
     
    403403        $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
    404404        $request->set_param( 'mycustomsetting', array() );
    405         $response = $this->server->dispatch( $request );
     405        $response = rest_get_server()->dispatch( $request );
    406406        $data     = $response->get_data();
    407407        $this->assertEquals( array(), $data['mycustomsetting'] );
     
    411411        $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
    412412        $request->set_param( 'mycustomsetting', array( 'invalid' ) );
    413         $response = $this->server->dispatch( $request );
     413        $response = rest_get_server()->dispatch( $request );
    414414
    415415        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     
    440440
    441441        // We have to re-register the route, as the args changes based off registered settings.
    442         $this->server->override_by_default = true;
     442        rest_get_server()->override_by_default = true;
    443443        $this->endpoint->register_routes();
    444444        wp_set_current_user( self::$administrator );
     
    453453            )
    454454        );
    455         $response = $this->server->dispatch( $request );
     455        $response = rest_get_server()->dispatch( $request );
    456456        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
    457457    }
     
    475475
    476476        // We have to re-register the route, as the args changes based off registered settings.
    477         $this->server->override_by_default = true;
     477        rest_get_server()->override_by_default = true;
    478478        $this->endpoint->register_routes();
    479479        wp_set_current_user( self::$administrator );
     
    481481        $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
    482482        $request->set_param( 'mycustomsetting', array( 'a' => 1 ) );
    483         $response = $this->server->dispatch( $request );
     483        $response = rest_get_server()->dispatch( $request );
    484484        $data     = $response->get_data();
    485485        $this->assertEquals( array( 'a' => 1 ), $data['mycustomsetting'] );
     
    489489        $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
    490490        $request->set_param( 'mycustomsetting', array() );
    491         $response = $this->server->dispatch( $request );
     491        $response = rest_get_server()->dispatch( $request );
    492492        $data     = $response->get_data();
    493493        $this->assertEquals( array(), $data['mycustomsetting'] );
     
    502502            )
    503503        );
    504         $response = $this->server->dispatch( $request );
     504        $response = rest_get_server()->dispatch( $request );
    505505
    506506        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
     
    509509        $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
    510510        $request->set_param( 'mycustomsetting', array( 'a' => 'invalid' ) );
    511         $response = $this->server->dispatch( $request );
     511        $response = rest_get_server()->dispatch( $request );
    512512        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
    513513        unregister_setting( 'somegroup', 'mycustomsetting' );
     
    520520        $request->set_param( 'title', 'The old title!' );
    521521        $request->set_param( 'description', 'The old description!' );
    522         $response = $this->server->dispatch( $request );
     522        $response = rest_get_server()->dispatch( $request );
    523523        $data     = $response->get_data();
    524524        $this->assertEquals( 200, $response->get_status() );
     
    533533        $request->set_param( 'title', 'The new title!' );
    534534        $request->set_param( 'description', 'The new description!' );
    535         $response = $this->server->dispatch( $request );
     535        $response = rest_get_server()->dispatch( $request );
    536536        $data     = $response->get_data();
    537537
     
    549549        $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
    550550        $request->set_param( 'title', array( 'rendered' => 'This should fail.' ) );
    551         $response = $this->server->dispatch( $request );
     551        $response = rest_get_server()->dispatch( $request );
    552552        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
    553553    }
     
    557557        $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
    558558        $request->set_param( 'posts_per_page', 11 );
    559         $response = $this->server->dispatch( $request );
     559        $response = rest_get_server()->dispatch( $request );
    560560        $this->assertEquals( 200, $response->get_status() );
    561561    }
     
    565565        $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
    566566        $request->set_param( 'posts_per_page', 10.5 );
    567         $response = $this->server->dispatch( $request );
     567        $response = rest_get_server()->dispatch( $request );
    568568        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
    569569    }
     
    578578        $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
    579579        $request->set_param( 'posts_per_page', null );
    580         $response = $this->server->dispatch( $request );
     580        $response = rest_get_server()->dispatch( $request );
    581581        $data     = $response->get_data();
    582582
     
    591591        $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
    592592        $request->set_param( 'default_ping_status', 'open&closed' );
    593         $response = $this->server->dispatch( $request );
     593        $response = rest_get_server()->dispatch( $request );
    594594        $this->assertErrorResponse( 'rest_invalid_param', $response, 400 );
    595595    }
     
    609609        $request = new WP_REST_Request( 'PUT', '/wp/v2/settings' );
    610610        $request->set_param( 'mycustomsetting', null );
    611         $response = $this->server->dispatch( $request );
     611        $response = rest_get_server()->dispatch( $request );
    612612
    613613        $this->assertErrorResponse( 'rest_invalid_stored_value', $response, 500 );
     
    617617        /** Settings can't be deleted */
    618618        $request  = new WP_REST_Request( 'DELETE', '/wp/v2/settings/title' );
    619         $response = $this->server->dispatch( $request );
     619        $response = rest_get_server()->dispatch( $request );
    620620        $this->assertEquals( 404, $response->get_status() );
    621621    }
Note: See TracChangeset for help on using the changeset viewer.