Changeset 42784

Timestamp:

03/05/2018 03:32:54 PM (7 years ago)

Author:

afercia

Message:

Accessibility: Change the media upload "Dismiss error" link to a button.

For better accessibility and semantics, user interface controls that perform an
action should be buttons. Links should exclusively be used for navigation.

Props Cheffheid, audrasjb.
Fixes #38671.

Location:

trunk/src/wp-admin

Files:

• async-upload.php (modified) (1 diff)
• css/media.css (modified) (1 diff)

trunk/src/wp-admin/async-upload.php

@@ -91 +91 @@
 if ( is_wp_error( $id ) ) {
     echo '<div class="error-div error">
-    <a class="dismiss" href="#" onclick="jQuery(this).parents(\'div.media-item\').slideUp(200, function(){jQuery(this).remove();});">' . __( 'Dismiss' ) . '</a>
+    <button type="button" class="dismiss button-link" onclick="jQuery(this).parents(\'div.media-item\').slideUp(200, function(){jQuery(this).remove();});">' . __( 'Dismiss' ) . '</button>
     <strong>' . sprintf( __( '&#8220;%s&#8221; has failed to upload.' ), esc_html( $_FILES['async-upload']['name'] ) ) . '</strong><br />' .
     esc_html( $id->get_error_message() ) . '</div>';

trunk/src/wp-admin/css/media.css

@@ -212 +212 @@
 }
 
-.media-item .error-div a.dismiss {
-    display: block;
+.media-item .error-div button.dismiss {
     float: right;
     margin: 0 10px 0 15px;