Changeset 42827 for trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php

Timestamp:

03/11/2018 04:43:59 PM (7 years ago)

Author:

SergeyBiryukov

Message:

I18N: Use the actual placeholder instead of a number in translator comments if the corresponding string does not use numbered placeholders.

Add missing translator comments in WP_Theme_Install_List_Table and wp_notify_postauthor().
Add missing commas in some translator comments.

Fixes #43523.

File:

• trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php (modified) (4 diffs)

trunk/src/wp-admin/includes/class-wp-theme-install-list-table.php

@@ -265 +265 @@
         $author = wp_kses( $theme->author, $themes_allowedtags );
 
+        /* translators: %s: theme name */
         $preview_title = sprintf( __( 'Preview “%s”' ), $name );
         $preview_url   = add_query_arg(
@@ -293 +294 @@
         switch ( $status ) {
             case 'update_available':
-                $actions[] = '<a class="install-now" href="' . esc_url( wp_nonce_url( $update_url, 'upgrade-theme_' . $theme->slug ) ) . '" title="' . esc_attr( sprintf( __( 'Update to version %s' ), $theme->version ) ) . '">' . __( 'Update' ) . '</a>';
+                $actions[] = sprintf(
+                    '<a class="install-now" href="%s" title="%s">%s</a>',
+                    esc_url( wp_nonce_url( $update_url, 'upgrade-theme_' . $theme->slug ) ),
+                    /* translators: %s: theme version */
+                    esc_attr( sprintf( __( 'Update to version %s' ), $theme->version ) ),
+                    __( 'Update' )
+                );
                 break;
             case 'newer_installed':
             case 'latest_installed':
-                $actions[] = '<span class="install-now" title="' . esc_attr__( 'This theme is already installed and is up to date' ) . '">' . _x( 'Installed', 'theme' ) . '</span>';
+                $actions[] = sprintf(
+                    '<span class="install-now" title="%s">%s</span>',
+                    esc_attr__( 'This theme is already installed and is up to date' ),
+                    _x( 'Installed', 'theme' )
+                );
                 break;
             case 'install':
             default:
-                $actions[] = '<a class="install-now" href="' . esc_url( wp_nonce_url( $install_url, 'install-theme_' . $theme->slug ) ) . '" title="' . esc_attr( sprintf( __( 'Install %s' ), $name ) ) . '">' . __( 'Install Now' ) . '</a>';
-                break;
-        }
-
-        $actions[] = '<a class="install-theme-preview" href="' . esc_url( $preview_url ) . '" title="' . esc_attr( sprintf( __( 'Preview %s' ), $name ) ) . '">' . __( 'Preview' ) . '</a>';
+                $actions[] = sprintf(
+                    '<a class="install-now" href="%s" title="%s">%s</a>',
+                    esc_url( wp_nonce_url( $install_url, 'install-theme_' . $theme->slug ) ),
+                    /* translators: %s: theme name */
+                    esc_attr( sprintf( __( 'Install %s' ), $name ) ),
+                    __( 'Install Now' )
+                );
+                break;
+        }
+
+        $actions[] = sprintf(
+            '<a class="install-theme-preview" href="%s" title="%s">%s</a>',
+            esc_url( $preview_url ),
+            /* translators: %s: theme name */
+            esc_attr( sprintf( __( 'Preview %s' ), $name ) ),
+            __( 'Preview' )
+        );
 
         /**
@@ -324 +347 @@
 
         <h3><?php echo $name; ?></h3>
-        <div class="theme-author"><?php printf( __( 'By %s' ), $author ); ?></div>
+        <div class="theme-author"><?php
+            /* translators: %s: theme author */
+            printf( __( 'By %s' ), $author );
+        ?></div>
 
         <div class="action-links">
@@ -422 +448 @@
         switch ( $status ) {
             case 'update_available':
-                echo '<a class="theme-install button button-primary" href="' . esc_url( wp_nonce_url( $update_url, 'upgrade-theme_' . $theme->slug ) ) . '" title="' . esc_attr( sprintf( __( 'Update to version %s' ), $theme->version ) ) . '">' . __( 'Update' ) . '</a>';
+                printf(
+                    '<a class="theme-install button button-primary" href="%s" title="%s">%s</a>',
+                    esc_url( wp_nonce_url( $update_url, 'upgrade-theme_' . $theme->slug ) ),
+                    /* translators: %s: theme version */
+                    esc_attr( sprintf( __( 'Update to version %s' ), $theme->version ) ),
+                    __( 'Update' )
+                );
                 break;
             case 'newer_installed':
             case 'latest_installed':
-                echo '<span class="theme-install" title="' . esc_attr__( 'This theme is already installed and is up to date' ) . '">' . _x( 'Installed', 'theme' ) . '</span>';
+                printf(
+                    '<span class="theme-install" title="%s">%s</span>',
+                    esc_attr__( 'This theme is already installed and is up to date' ),
+                    _x( 'Installed', 'theme' )
+                );
                 break;
             case 'install':
             default:
-                echo '<a class="theme-install button button-primary" href="' . esc_url( wp_nonce_url( $install_url, 'install-theme_' . $theme->slug ) ) . '">' . __( 'Install' ) . '</a>';
+                printf(
+                    '<a class="theme-install button button-primary" href="%s">%s</a>',
+                    esc_url( wp_nonce_url( $install_url, 'install-theme_' . $theme->slug ) ),
+                    __( 'Install' )
+                );
                 break;
         }
             ?>
             <h3 class="theme-name"><?php echo $name; ?></h3>
-            <span class="theme-by"><?php printf( __( 'By %s' ), $author ); ?></span>
+            <span class="theme-by"><?php
+                /* translators: %s: theme author */
+                printf( __( 'By %s' ), $author );
+            ?></span>
             <?php if ( isset( $theme->screenshot_url ) ) : ?>
                 <img class="theme-screenshot" src="<?php echo esc_url( $theme->screenshot_url ); ?>" alt="" />