Changeset 42829

Timestamp:

03/12/2018 01:56:20 AM (7 years ago)

Author:

dd32

Message:

Plugins: Add support for plugins having an active_installs value larger than 1 million.
WordPress.org currently supports up to 5 million, and with the growth of WordPress, it's expected that that upper bound will increase in the future.

Fixes #43193.

Location:

trunk/src/wp-admin/includes

Files:

• class-wp-plugin-install-list-table.php (modified) (1 diff)
• plugin-install.php (modified) (1 diff)

trunk/src/wp-admin/includes/class-wp-plugin-install-list-table.php

@@ -651 +651 @@
                     <?php
                     if ( $plugin['active_installs'] >= 1000000 ) {
-                        $active_installs_text = _x( '1+ Million', 'Active plugin installations' );
+                        $active_installs_millions = floor( $plugin['active_installs'] / 1000000 );
+                        $active_installs_text = sprintf(
+                            _nx( '%s+ Million', '%s+ Million', 'Active plugin installations', $active_installs_millions ),
+                            number_format_i18n( $active_installs_millions )
+                        );
                     } elseif ( 0 == $plugin['active_installs'] ) {
                         $active_installs_text = _x( 'Less Than 10', 'Active plugin installations' );

trunk/src/wp-admin/includes/plugin-install.php

@@ -653 +653 @@
                                         <?php
                                         if ( $api->active_installs >= 1000000 ) {
-                                            _ex( '1+ Million', 'Active plugin installations' );
+                                            $active_installs_millions = floor( $api->active_installs / 1000000 );
+                                            printf(
+                                                _nx( '%s+ Million', '%s+ Million', 'Active plugin installations', $active_installs_millions ),
+                                                number_format_i18n( $active_installs_millions )
+                                            );
                                         } elseif ( 0 == $api->active_installs ) {
                                             _ex( 'Less Than 10', 'Active plugin installations' );